Skip to content

Creating tax records based on a newly created recurring tax record dated in the past #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
Scorpoon opened this issue Nov 28, 2024 · 3 comments
Closed
4 tasks done

Creating tax records based on a newly created recurring tax record dated in the past #745

Scorpoon opened this issue Nov 28, 2024 · 3 comments
Assignees
@hargata
Labels
pending release fix in place, pending release

Comments

@Scorpoon
Copy link
Contributor

Checklist
Please make sure you have performed the following steps before opening a new bug ticket, change [ ] to [x] to mark it as done

  • I have read and tried the steps outlined in the Troubleshooting Guide
  • I have searched through existing issues.

Description
Currently when a recurring tax record with a date in the past is created, previous records aren't inserted during the saving process.
One record a time is added each time the vehicle is reopened (see VehilceController.Index(): UpdateRecurringTaxes(vehicleId);, so f.e. if a recurring record was added with start date 01.01.2024 (recurring monthly), each time the vehicle is opened another month record is added until new date is < DateTime.Now.
This seems to me like a bug or not fully implemented feature.

Platform

  • Docker Image
  • Windows Standalone Executable
@Scorpoon Scorpoon changed the title Creating tax records based on a newly created recurring tax records dated in the past Creating tax records based on a newly created recurring tax record dated in the past Nov 28, 2024
@Scorpoon Scorpoon mentioned this issue Nov 28, 2024
Closed
@hargata hargata mentioned this issue Nov 29, 2024
Merged
@hargata
Copy link
Owner

hargata commented Nov 29, 2024

Next Release

pasttaxrecord

@Scorpoon
Copy link
Contributor Author

Looks good. Thanks

@hargata hargata self-assigned this Dec 4, 2024
@hargata hargata added the pending release fix in place, pending release label Dec 4, 2024
@hargata
Copy link
Owner

hargata commented Jan 2, 2025

Released

@hargata hargata closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hargata hargata

Labels
pending release fix in place, pending release
Projects
None yet
Milestone
No milestone
2 participants
@Scorpoon @hargata