Remove redundant .ToArray()/.ToList() (#2944)

* Remove for Task.WhenAll

* Remove for ConcurrentDictionary

* Use collection expressions

* Use for ConucrrentDictionary

* Use for string.Join

* Change signature for PageCoverage.ConvertToDisjointRanges

* Fix for BrowserData/Chrome as it is not ConcurrentDictionary

* Bump SixLabors.ImageSharp to 3.1.17

Author: IliaBrahinets

lib/PuppeteerSharp.Tests/PuppeteerSharp.Tests.csproj

@@ -18,7 +18,7 @@
 		</PackageReference>
 		<PackageReference Include="NUnit3TestAdapter" Version="4.6.0" />
 		<PackageReference Include="System.Net.Http" Version="4.3.4" />
-		<PackageReference Include="SixLabors.ImageSharp" Version="3.1.7" />
+		<PackageReference Include="SixLabors.ImageSharp" Version="3.1.11" />
 		<PackageReference Include="Microsoft.AspNetCore.Connections.Abstractions" Version="2.2.0" />
 	</ItemGroup>
 	<Import Project="../Common/CommonProps.props" />

lib/PuppeteerSharp/Binding.cs

@@ -136,7 +136,7 @@ await context.EvaluateFunctionAsync(
             }
             finally
             {
-                await Task.WhenAll(garbage.ToArray()).ConfigureAwait(false);
+                await Task.WhenAll(garbage).ConfigureAwait(false);
             }
         }
     }

lib/PuppeteerSharp/BrowserData/Firefox.cs

@@ -123,7 +123,7 @@ private static void SyncPreferences(Dictionary<string, object> defaultPreference
             var userPath = Path.Combine(tempUserDataDirectory, "user.js");
             var lines = string.Join(
                 "\n",
-                defaultPreferences.Select(i => $"user_pref({JsonSerializer.Serialize(i.Key)}, {JsonSerializer.Serialize(i.Value)});").ToArray());
+                defaultPreferences.Select(i => $"user_pref({JsonSerializer.Serialize(i.Key)}, {JsonSerializer.Serialize(i.Value)});"));
 
             BackupFile(userPath);
             BackupFile(prefsPath);

lib/PuppeteerSharp/Cdp/CdpBrowser.cs

@@ -143,15 +143,7 @@ public override async Task<IBrowserContext> CreateBrowserContextAsync(BrowserCon
     }
 
     /// <inheritdoc/>
-    public override IBrowserContext[] BrowserContexts()
-    {
-        var contexts = _contexts.Values.ToArray<IBrowserContext>();
-
-        var allContexts = new IBrowserContext[contexts.Length + 1];
-        allContexts[0] = DefaultContext;
-        contexts.CopyTo(allContexts, 1);
-        return allContexts;
-    }
+    public override IBrowserContext[] BrowserContexts() => [DefaultContext, .. _contexts.Values];
 
     internal static async Task<CdpBrowser> CreateAsync(
         SupportedBrowser browserToCreate,

lib/PuppeteerSharp/Cdp/CdpCDPSession.cs

@@ -149,7 +149,7 @@ internal override void Close(string closeReason)
         CloseReason = closeReason;
         IsClosed = true;
 
-        foreach (var callback in _callbacks.Values.ToArray())
+        foreach (var callback in _callbacks.Values)
         {
             callback.TaskWrapper.TrySetException(new TargetClosedException(
                 $"Protocol error({callback.Method}): Target closed.",

lib/PuppeteerSharp/Cdp/Connection.cs

@@ -208,14 +208,14 @@ internal void Close(string closeReason)
             Transport.StopReading();
             Disconnected?.Invoke(this, EventArgs.Empty);
 
-            foreach (var session in _sessions.Values.ToArray())
+            foreach (var session in _sessions.Values)
             {
                 session.Close(closeReason);
             }
 
             _sessions.Clear();
 
-            foreach (var response in _callbacks.Values.ToArray())
+            foreach (var response in _callbacks.Values)
             {
                 response.TaskWrapper.TrySetException(new TargetClosedException(
                     $"Protocol error({response.Method}): Target closed.",

lib/PuppeteerSharp/Cdp/FrameManager.cs

@@ -283,7 +283,7 @@ private void OnLifeCycleEvent(LifecycleEventResponse e)
 
         private void OnExecutionContextsCleared(CDPSession session)
         {
-            foreach (var key in _contextIdToContext.Keys.ToArray())
+            foreach (var key in _contextIdToContext.Keys)
             {
                 var context = _contextIdToContext[key];
                 if (context.Client != session)

lib/PuppeteerSharp/PageCoverage/CSSCoverage.cs

@@ -93,7 +93,7 @@ await Task.WhenAll(
                 var url = kv.Value.Url;
                 var text = kv.Value.Source;
                 styleSheetIdToCoverage.TryGetValue(styleSheetId, out var responseRanges);
-                var ranges = Coverage.ConvertToDisjointRanges(responseRanges ?? new List<CoverageRange>());
+                var ranges = Coverage.ConvertToDisjointRanges(responseRanges ?? []);
                 coverage.Add(new CoverageEntry
                 {
                     Url = url,

lib/PuppeteerSharp/PageCoverage/Coverage.cs

@@ -30,7 +30,7 @@ public Task StartCSSCoverageAsync(CoverageStartOptions options = null)
         /// <inheritdoc/>
         public Task<CoverageEntry[]> StopCSSCoverageAsync() => _cssCoverage.StopAsync();
 
-        internal static CoverageEntryRange[] ConvertToDisjointRanges(List<CoverageRange> nestedRanges)
+        internal static CoverageEntryRange[] ConvertToDisjointRanges(IEnumerable<CoverageRange> nestedRanges)
         {
             var points = new List<CoverageEntryPoint>();
             foreach (var range in nestedRanges)

lib/PuppeteerSharp/PageCoverage/JSCoverage.cs

@@ -93,7 +93,7 @@ await Task.WhenAll(
                     continue;
                 }
 
-                var flattenRanges = entry.Functions.SelectMany(f => f.Ranges).ToList();
+                var flattenRanges = entry.Functions.SelectMany(f => f.Ranges);
                 var ranges = Coverage.ConvertToDisjointRanges(flattenRanges);
                 coverage.Add(new JSCoverageEntry
                 {