Undo breaking change (#2412)

kblok · web-flow · commit 50e11abc83eb · 2024-01-25T11:57:12.000-03:00
diff --git a/lib/PuppeteerSharp.Tests/BrowserContextTests/BrowserContextTests.cs b/lib/PuppeteerSharp.Tests/BrowserContextTests/BrowserContextTests.cs
@@ -184,7 +184,7 @@ public async Task ShouldTimeoutWaitingForNonExistentTarget()
         {
             var context = await Browser.CreateIncognitoBrowserContextAsync();
             Assert.ThrowsAsync<TimeoutException>(()
-                => context.WaitForTargetAsync((target) => target.Url == TestConstants.EmptyPage, new WaitTimeoutOptions(1)));
+                => context.WaitForTargetAsync((target) => target.Url == TestConstants.EmptyPage, new WaitForOptions(1)));
             await context.CloseAsync();
         }
     }
diff --git a/lib/PuppeteerSharp.Tests/DeviceRequestPromptTests/DeviceRequestPromptWaitForDeviceTests.cs b/lib/PuppeteerSharp.Tests/DeviceRequestPromptTests/DeviceRequestPromptWaitForDeviceTests.cs
@@ -141,7 +141,7 @@ public void ShouldRespectTimeout()
             {
                 Id = "000",
             });
-        Assert.ThrowsAsync<TimeoutException>(() => prompt.WaitForDeviceAsync(device => device.Name == "My Device 1", new WaitTimeoutOptions(1)));
+        Assert.ThrowsAsync<TimeoutException>(() => prompt.WaitForDeviceAsync(device => device.Name == "My Device 1", new WaitForOptions(1)));
     }
 
     [PuppeteerTest("DeviceRequestPrompt.test.ts", "DeviceRequestPrompt.waitForDevice", "should respect default timeout when there is no custom timeout")]
@@ -175,7 +175,7 @@ public void ShouldPrioritizeExactTimeoutOverDefaultTimeout()
                 Id = "000",
             });
         timeoutSettings.Timeout = 0;
-        Assert.ThrowsAsync<TimeoutException>(() => prompt.WaitForDeviceAsync(device => device.Name == "My Device 1", new WaitTimeoutOptions(1)));
+        Assert.ThrowsAsync<TimeoutException>(() => prompt.WaitForDeviceAsync(device => device.Name == "My Device 1", new WaitForOptions(1)));
     }
 
     [PuppeteerTest("DeviceRequestPrompt.test.ts", "DeviceRequestPrompt.waitForDevice", "should work with no timeout")]
@@ -191,7 +191,7 @@ public async Task ShouldWorkWithNoTimeout()
             {
                 Id = "000",
             });
-        var deviceTask = prompt.WaitForDeviceAsync(device => device.Name == "My Device 1", new WaitTimeoutOptions(0));
+        var deviceTask = prompt.WaitForDeviceAsync(device => device.Name == "My Device 1", new WaitForOptions(0));
 
         var promptData = new DeviceAccessDeviceRequestPromptedResponse()
         {
diff --git a/lib/PuppeteerSharp.Tests/DeviceRequestPromptTests/WaitForDevicePromptTests.cs b/lib/PuppeteerSharp.Tests/DeviceRequestPromptTests/WaitForDevicePromptTests.cs
@@ -85,7 +85,7 @@ public void ShouldRespectTimeout()
             var client =  new MockCDPSession();
             var timeoutSettings = new TimeoutSettings();
             var manager = new DeviceRequestPromptManager(client, timeoutSettings);
-            Assert.ThrowsAsync<TimeoutException>(() => manager.WaitForDevicePromptAsync(new WaitTimeoutOptions(1)));
+            Assert.ThrowsAsync<TimeoutException>(() => manager.WaitForDevicePromptAsync(new WaitForOptions(1)));
         }
 
         [PuppeteerTest("DeviceRequestPrompt.test.ts", "waitForDevicePrompt", "should respect default timeout when there is no custom timeout")]
@@ -107,7 +107,7 @@ public void ShouldPrioritizeExactTimeoutOverDefaultTimeout()
             var timeoutSettings = new TimeoutSettings();
             var manager = new DeviceRequestPromptManager(client, timeoutSettings);
             timeoutSettings.Timeout = 0;
-            Assert.ThrowsAsync<TimeoutException>(() => manager.WaitForDevicePromptAsync(new WaitTimeoutOptions(1)));
+            Assert.ThrowsAsync<TimeoutException>(() => manager.WaitForDevicePromptAsync(new WaitForOptions(1)));
         }
 
         [PuppeteerTest("DeviceRequestPrompt.test.ts", "waitForDevicePrompt", "should work with no timeout")]
@@ -117,7 +117,7 @@ public async Task ShouldWorkWithNoTimeout()
             var client =  new MockCDPSession();
             var timeoutSettings = new TimeoutSettings();
             var manager = new DeviceRequestPromptManager(client, timeoutSettings);
-            var promptTask = manager.WaitForDevicePromptAsync(new WaitTimeoutOptions(0));
+            var promptTask = manager.WaitForDevicePromptAsync(new WaitForOptions(0));
             var promptData = new DeviceAccessDeviceRequestPromptedResponse()
             {
                 Id = "00000000000000000000000000000000",
diff --git a/lib/PuppeteerSharp.Tests/InputTests/PageWaitForFileChooserTests.cs b/lib/PuppeteerSharp.Tests/InputTests/PageWaitForFileChooserTests.cs
@@ -49,7 +49,7 @@ await Task.WhenAll(
         [Skip(SkipAttribute.Targets.Firefox)]
         public void ShouldRespectTimeout()
         {
-            Assert.ThrowsAsync<TimeoutException>(() => Page.WaitForFileChooserAsync(new WaitTimeoutOptions
+            Assert.ThrowsAsync<TimeoutException>(() => Page.WaitForFileChooserAsync(new WaitForOptions
             {
                 Timeout = 1
             }));
@@ -68,7 +68,7 @@ public void ShouldRespectTimeoutWhenThereIsNoCustomTimeout()
         public void ShouldPrioritizeExactTimeoutOverDefaultTimeout()
         {
             Page.DefaultTimeout = 0;
-            Assert.ThrowsAsync<TimeoutException>(() => Page.WaitForFileChooserAsync(new WaitTimeoutOptions
+            Assert.ThrowsAsync<TimeoutException>(() => Page.WaitForFileChooserAsync(new WaitForOptions
             {
                 Timeout = 1
             }));
@@ -78,7 +78,7 @@ public void ShouldPrioritizeExactTimeoutOverDefaultTimeout()
         [Skip(SkipAttribute.Targets.Firefox)]
         public async Task ShouldWorkWithNoTimeout()
         {
-            var waitForTask = Page.WaitForFileChooserAsync(new WaitTimeoutOptions { Timeout = 0 });
+            var waitForTask = Page.WaitForFileChooserAsync(new WaitForOptions { Timeout = 0 });
 
             await Task.WhenAll(
                 waitForTask,
diff --git a/lib/PuppeteerSharp.Tests/PageTests/WaitForRequestTests.cs b/lib/PuppeteerSharp.Tests/PageTests/WaitForRequestTests.cs
@@ -50,7 +50,7 @@ public async Task ShouldRespectTimeout()
         {
             await Page.GoToAsync(TestConstants.EmptyPage);
             var exception = Assert.ThrowsAsync<TimeoutException>(async () =>
-                await Page.WaitForRequestAsync(_ => false, new WaitTimeoutOptions(1)));
+                await Page.WaitForRequestAsync(_ => false, new WaitForOptions(1)));
 
             StringAssert.Contains("Timeout of 1 ms exceeded", exception.Message);
         }
@@ -72,7 +72,7 @@ public async Task ShouldRespectDefaultTimeout()
         public async Task ShouldWorkWithNoTimeout()
         {
             await Page.GoToAsync(TestConstants.EmptyPage);
-            var task = Page.WaitForRequestAsync(TestConstants.ServerUrl + "/digits/2.png", new WaitTimeoutOptions(0));
+            var task = Page.WaitForRequestAsync(TestConstants.ServerUrl + "/digits/2.png", new WaitForOptions(0));
 
             await Task.WhenAll(
                 task,
diff --git a/lib/PuppeteerSharp.Tests/PageTests/WaitForResponseTests.cs b/lib/PuppeteerSharp.Tests/PageTests/WaitForResponseTests.cs
@@ -77,7 +77,7 @@ public async Task ShouldRespectTimeout()
         {
             await Page.GoToAsync(TestConstants.EmptyPage);
             var exception = Assert.ThrowsAsync<TimeoutException>(async () =>
-                await Page.WaitForResponseAsync(_ => false, new WaitTimeoutOptions(1)));
+                await Page.WaitForResponseAsync(_ => false, new WaitForOptions(1)));
 
             StringAssert.Contains("Timeout of 1 ms exceeded", exception.Message);
         }
@@ -99,7 +99,7 @@ public async Task ShouldRespectDefaultTimeout()
         public async Task ShouldWorkWithNoTimeout()
         {
             await Page.GoToAsync(TestConstants.EmptyPage);
-            var task = Page.WaitForResponseAsync(TestConstants.ServerUrl + "/digits/2.png", new WaitTimeoutOptions(0));
+            var task = Page.WaitForResponseAsync(TestConstants.ServerUrl + "/digits/2.png", new WaitForOptions(0));
 
             await Task.WhenAll(
                 task,
diff --git a/lib/PuppeteerSharp/Browser.cs b/lib/PuppeteerSharp/Browser.cs
@@ -199,7 +199,7 @@ public void Disconnect()
         public Task CloseAsync() => _closeTask ?? (_closeTask = CloseCoreAsync());
 
         /// <inheritdoc/>
-        public async Task<ITarget> WaitForTargetAsync(Func<ITarget, bool> predicate, WaitTimeoutOptions options = null)
+        public async Task<ITarget> WaitForTargetAsync(Func<ITarget, bool> predicate, WaitForOptions options = null)
         {
             if (predicate == null)
             {
diff --git a/lib/PuppeteerSharp/BrowserContext.cs b/lib/PuppeteerSharp/BrowserContext.cs
@@ -46,7 +46,7 @@ internal BrowserContext(Connection connection, Browser browser, string contextId
         public ITarget[] Targets() => Array.FindAll(Browser.Targets(), target => target.BrowserContext == this);
 
         /// <inheritdoc/>
-        public Task<ITarget> WaitForTargetAsync(Func<ITarget, bool> predicate, WaitTimeoutOptions options = null)
+        public Task<ITarget> WaitForTargetAsync(Func<ITarget, bool> predicate, WaitForOptions options = null)
             => Browser.WaitForTargetAsync((target) => target.BrowserContext == this && predicate(target), options);
 
         /// <inheritdoc/>
diff --git a/lib/PuppeteerSharp/DeviceRequestPrompt.cs b/lib/PuppeteerSharp/DeviceRequestPrompt.cs
@@ -84,7 +84,7 @@ public Task SelectAsync(DeviceRequestPromptDevice device)
     /// <param name="filter">The filter to apply.</param>
     /// <param name="options">The options.</param>
     /// <returns>A task that resolves to the first device matching the filter.</returns>
-    public Task<DeviceRequestPromptDevice> WaitForDeviceAsync(Func<DeviceRequestPromptDevice, bool> filter, WaitTimeoutOptions options = default)
+    public Task<DeviceRequestPromptDevice> WaitForDeviceAsync(Func<DeviceRequestPromptDevice, bool> filter, WaitForOptions options = default)
     {
         foreach (var device in Devices.Where(filter))
         {
diff --git a/lib/PuppeteerSharp/DeviceRequestPromptManager.cs b/lib/PuppeteerSharp/DeviceRequestPromptManager.cs
@@ -40,7 +40,7 @@ internal DeviceRequestPromptManager(ICDPSession client, TimeoutSettings timeoutS
         _client.MessageReceived += OnMessageReceived;
     }
 
-    public async Task<DeviceRequestPrompt> WaitForDevicePromptAsync(WaitTimeoutOptions options = default)
+    public async Task<DeviceRequestPrompt> WaitForDevicePromptAsync(WaitForOptions options = default)
     {
         if (_client == null)
         {
diff --git a/lib/PuppeteerSharp/FileChooser.cs b/lib/PuppeteerSharp/FileChooser.cs
@@ -7,7 +7,7 @@
 namespace PuppeteerSharp
 {
     /// <summary>
-    /// <see cref="FileChooser"/> objects are returned via the <seealso cref="IPage.WaitForFileChooserAsync(WaitTimeoutOptions)"/> method.
+    /// <see cref="FileChooser"/> objects are returned via the <seealso cref="IPage.WaitForFileChooserAsync(WaitForOptions)"/> method.
     /// File choosers let you react to the page requesting for a file.
     /// </summary>
     /// <example>
diff --git a/lib/PuppeteerSharp/Frame.cs b/lib/PuppeteerSharp/Frame.cs
@@ -269,7 +269,7 @@ public async Task<IElementHandle[]> XPathAsync(string expression)
         }
 
         /// <inheritdoc/>
-        public Task<DeviceRequestPrompt> WaitForDevicePromptAsync(WaitTimeoutOptions options = default)
+        public Task<DeviceRequestPrompt> WaitForDevicePromptAsync(WaitForOptions options = default)
             => GetDeviceRequestPromptManager().WaitForDevicePromptAsync(options);
 
         /// <inheritdoc/>
diff --git a/lib/PuppeteerSharp/IBrowser.cs b/lib/PuppeteerSharp/IBrowser.cs
@@ -208,7 +208,7 @@ public interface IBrowser : IDisposable, IAsyncDisposable
         /// <param name="predicate">A function to be run for every target.</param>
         /// <param name="options">options.</param>
         /// <returns>Resolves to the first target found that matches the predicate function.</returns>
-        Task<ITarget> WaitForTargetAsync(Func<ITarget, bool> predicate, WaitTimeoutOptions options = null);
+        Task<ITarget> WaitForTargetAsync(Func<ITarget, bool> predicate, WaitForOptions options = null);
 
         /// <summary>
         /// Registers a custom query handler.
diff --git a/lib/PuppeteerSharp/IBrowserContext.cs b/lib/PuppeteerSharp/IBrowserContext.cs
@@ -112,6 +112,6 @@ public interface IBrowserContext
         /// <param name="predicate">A function to be run for every target.</param>
         /// <param name="options">options.</param>
         /// <returns>Resolves to the first target found that matches the predicate function.</returns>
-        Task<ITarget> WaitForTargetAsync(Func<ITarget, bool> predicate, WaitTimeoutOptions options = null);
+        Task<ITarget> WaitForTargetAsync(Func<ITarget, bool> predicate, WaitForOptions options = null);
     }
 }
diff --git a/lib/PuppeteerSharp/IFrame.cs b/lib/PuppeteerSharp/IFrame.cs
@@ -445,6 +445,6 @@ public interface IFrame
         /// </example>
         /// <param name="options">Optional waiting parameters.</param>
         /// <returns>A task that resolves after the page gets the prompt.</returns>
-        Task<DeviceRequestPrompt> WaitForDevicePromptAsync(WaitTimeoutOptions options = null);
+        Task<DeviceRequestPrompt> WaitForDevicePromptAsync(WaitForOptions options = null);
     }
 }
diff --git a/lib/PuppeteerSharp/IPage.cs b/lib/PuppeteerSharp/IPage.cs
@@ -205,8 +205,8 @@ public interface IPage : IDisposable, IAsyncDisposable
         /// - <see cref="SetContentAsync(string, NavigationOptions)"/>
         /// - <see cref="WaitForFunctionAsync(string, object[])"/>
         /// - <see cref="WaitForNavigationAsync(NavigationOptions)"/>
-        /// - <see cref="WaitForRequestAsync(string, WaitTimeoutOptions)"/>
-        /// - <see cref="WaitForResponseAsync(string, WaitTimeoutOptions)"/>
+        /// - <see cref="WaitForRequestAsync(string, WaitForOptions)"/>
+        /// - <see cref="WaitForResponseAsync(string, WaitForOptions)"/>
         /// - <see cref="WaitForSelectorAsync(string, WaitForSelectorOptions)"/>
         /// - <see cref="WaitForExpressionAsync(string, WaitForFunctionOptions)"/>.
         /// </summary>
@@ -1185,7 +1185,7 @@ public interface IPage : IDisposable, IAsyncDisposable
         /// <returns>A task which resolves when a matching frame was attached to the page.</returns>
         /// <param name="url">Frame url.</param>
         /// <param name="options">Options.</param>
-        public Task<IFrame> WaitForFrameAsync(string url, WaitTimeoutOptions options = null);
+        public Task<IFrame> WaitForFrameAsync(string url, WaitForOptions options = null);
 
         /// <summary>
         /// Waits for a frame.
@@ -1200,7 +1200,7 @@ public interface IPage : IDisposable, IAsyncDisposable
         /// <returns>A task which resolves when a matching frame was attached to the page.</returns>
         /// <param name="predicate">Function which looks for a matching frame.</param>
         /// <param name="options">Options.</param>
-        public Task<IFrame> WaitForFrameAsync(Func<IFrame, bool> predicate, WaitTimeoutOptions options = null);
+        public Task<IFrame> WaitForFrameAsync(Func<IFrame, bool> predicate, WaitForOptions options = null);
 
         /// <summary>
         /// Waits for a page to open a file picker.
@@ -1227,7 +1227,7 @@ public interface IPage : IDisposable, IAsyncDisposable
         /// </example>
         /// <param name="options">Optional waiting parameters.</param>
         /// <returns>A task that resolves after a page requests a file picker.</returns>
-        Task<FileChooser> WaitForFileChooserAsync(WaitTimeoutOptions options = null);
+        Task<FileChooser> WaitForFileChooserAsync(WaitForOptions options = null);
 
         /// <summary>
         /// Waits for a function to be evaluated to a truthy value.
@@ -1299,7 +1299,7 @@ public interface IPage : IDisposable, IAsyncDisposable
         /// <returns>A task which resolves when a matching request was made.</returns>
         /// <param name="predicate">Function which looks for a matching request.</param>
         /// <param name="options">Options.</param>
-        Task<IRequest> WaitForRequestAsync(Func<IRequest, bool> predicate, WaitTimeoutOptions options = null);
+        Task<IRequest> WaitForRequestAsync(Func<IRequest, bool> predicate, WaitForOptions options = null);
 
         /// <summary>
         /// Waits for a request.
@@ -1315,7 +1315,7 @@ public interface IPage : IDisposable, IAsyncDisposable
         /// <returns>A task which resolves when a matching request was made.</returns>
         /// <param name="url">URL to wait for.</param>
         /// <param name="options">Options.</param>
-        Task<IRequest> WaitForRequestAsync(string url, WaitTimeoutOptions options = null);
+        Task<IRequest> WaitForRequestAsync(string url, WaitForOptions options = null);
 
         /// <summary>
         /// Waits for a response.
@@ -1331,7 +1331,7 @@ public interface IPage : IDisposable, IAsyncDisposable
         /// <returns>A task which resolves when a matching response is received.</returns>
         /// <param name="predicate">Function which looks for a matching response.</param>
         /// <param name="options">Options.</param>
-        Task<IResponse> WaitForResponseAsync(Func<IResponse, bool> predicate, WaitTimeoutOptions options = null);
+        Task<IResponse> WaitForResponseAsync(Func<IResponse, bool> predicate, WaitForOptions options = null);
 
         /// <summary>
         /// Waits for a response.
@@ -1347,7 +1347,7 @@ public interface IPage : IDisposable, IAsyncDisposable
         /// <returns>A task which resolves when a matching response is received.</returns>
         /// <param name="predicate">Function which looks for a matching response.</param>
         /// <param name="options">Options.</param>
-        Task<IResponse> WaitForResponseAsync(Func<IResponse, Task<bool>> predicate, WaitTimeoutOptions options = null);
+        Task<IResponse> WaitForResponseAsync(Func<IResponse, Task<bool>> predicate, WaitForOptions options = null);
 
         /// <summary>
         /// Waits for a response.
@@ -1363,7 +1363,7 @@ public interface IPage : IDisposable, IAsyncDisposable
         /// <returns>A task which resolves when a matching response is received.</returns>
         /// <param name="url">URL to wait for.</param>
         /// <param name="options">Options.</param>
-        Task<IResponse> WaitForResponseAsync(string url, WaitTimeoutOptions options = null);
+        Task<IResponse> WaitForResponseAsync(string url, WaitForOptions options = null);
 
         /// <summary>
         /// Waits for a selector to be added to the DOM.
@@ -1437,7 +1437,7 @@ public interface IPage : IDisposable, IAsyncDisposable
         /// </example>
         /// <param name="options">Optional waiting parameters.</param>
         /// <returns>A task that resolves after the page gets the prompt.</returns>
-        Task<DeviceRequestPrompt> WaitForDevicePromptAsync(WaitTimeoutOptions options = null);
+        Task<DeviceRequestPrompt> WaitForDevicePromptAsync(WaitForOptions options = null);
 
         /// <summary>
         /// <see cref="IRequest.RespondAsync"/>, <see cref="IRequest.AbortAsync"/>, and <see cref="IRequest.ContinueAsync"/> can accept an optional `priority` to activate Cooperative Intercept Mode.
diff --git a/lib/PuppeteerSharp/IResponse.cs b/lib/PuppeteerSharp/IResponse.cs
@@ -13,7 +13,7 @@ namespace PuppeteerSharp
     /// <seealso cref="IPage.GoForwardAsync(NavigationOptions)"/>
     /// <seealso cref="IPage.ReloadAsync(int?, WaitUntilNavigation[])"/>
     /// <seealso cref="IPage.Response"/>
-    /// <seealso cref="IPage.WaitForResponseAsync(Func{IResponse, bool}, WaitTimeoutOptions)"/>
+    /// <seealso cref="IPage.WaitForResponseAsync(Func{IResponse, bool}, WaitForOptions)"/>
     public interface IResponse
     {
         /// <summary>
diff --git a/lib/PuppeteerSharp/Page.cs b/lib/PuppeteerSharp/Page.cs
diff --git a/lib/PuppeteerSharp/PuppeteerSharp.csproj b/lib/PuppeteerSharp/PuppeteerSharp.csproj
diff --git a/lib/PuppeteerSharp/WaitForFunctionOptions.cs b/lib/PuppeteerSharp/WaitForFunctionOptions.cs
diff --git a/lib/PuppeteerSharp/WaitForNetworkIdleOptions.cs b/lib/PuppeteerSharp/WaitForNetworkIdleOptions.cs
diff --git a/lib/PuppeteerSharp/WaitForOptions.cs b/lib/PuppeteerSharp/WaitForOptions.cs
diff --git a/lib/PuppeteerSharp/WaitForSelectorOptions.cs b/lib/PuppeteerSharp/WaitForSelectorOptions.cs

Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,7 @@ public async Task ShouldTimeoutWaitingForNonExistentTarget()`
`184`	`184`	`{`
`185`	`185`	`var context = await Browser.CreateIncognitoBrowserContextAsync();`
`186`	`186`	`Assert.ThrowsAsync<TimeoutException>(()`
`187`		`- => context.WaitForTargetAsync((target) => target.Url == TestConstants.EmptyPage, new WaitTimeoutOptions(1)));`
	`187`	`+ => context.WaitForTargetAsync((target) => target.Url == TestConstants.EmptyPage, new WaitForOptions(1)));`
`188`	`188`	`await context.CloseAsync();`
`189`	`189`	`}`
`190`	`190`	`}`
Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ public void ShouldRespectTimeout()`
`141`	`141`	`{`
`142`	`142`	`Id = "000",`
`143`	`143`	`});`
`144`		`- Assert.ThrowsAsync<TimeoutException>(() => prompt.WaitForDeviceAsync(device => device.Name == "My Device 1", new WaitTimeoutOptions(1)));`
	`144`	`+ Assert.ThrowsAsync<TimeoutException>(() => prompt.WaitForDeviceAsync(device => device.Name == "My Device 1", new WaitForOptions(1)));`
`145`	`145`	`}`
`146`	`146`
`147`	`147`	`[PuppeteerTest("DeviceRequestPrompt.test.ts", "DeviceRequestPrompt.waitForDevice", "should respect default timeout when there is no custom timeout")]`
`@@ -175,7 +175,7 @@ public void ShouldPrioritizeExactTimeoutOverDefaultTimeout()`
`175`	`175`	`Id = "000",`
`176`	`176`	`});`
`177`	`177`	`timeoutSettings.Timeout = 0;`
`178`		`- Assert.ThrowsAsync<TimeoutException>(() => prompt.WaitForDeviceAsync(device => device.Name == "My Device 1", new WaitTimeoutOptions(1)));`
	`178`	`+ Assert.ThrowsAsync<TimeoutException>(() => prompt.WaitForDeviceAsync(device => device.Name == "My Device 1", new WaitForOptions(1)));`
`179`	`179`	`}`
`180`	`180`
`181`	`181`	`[PuppeteerTest("DeviceRequestPrompt.test.ts", "DeviceRequestPrompt.waitForDevice", "should work with no timeout")]`
`@@ -191,7 +191,7 @@ public async Task ShouldWorkWithNoTimeout()`
`191`	`191`	`{`
`192`	`192`	`Id = "000",`
`193`	`193`	`});`
`194`		`- var deviceTask = prompt.WaitForDeviceAsync(device => device.Name == "My Device 1", new WaitTimeoutOptions(0));`
	`194`	`+ var deviceTask = prompt.WaitForDeviceAsync(device => device.Name == "My Device 1", new WaitForOptions(0));`
`195`	`195`
`196`	`196`	`var promptData = new DeviceAccessDeviceRequestPromptedResponse()`
`197`	`197`	`{`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ await Task.WhenAll(`
`49`	`49`	`[Skip(SkipAttribute.Targets.Firefox)]`
`50`	`50`	`public void ShouldRespectTimeout()`
`51`	`51`	`{`
`52`		`- Assert.ThrowsAsync<TimeoutException>(() => Page.WaitForFileChooserAsync(new WaitTimeoutOptions`
	`52`	`+ Assert.ThrowsAsync<TimeoutException>(() => Page.WaitForFileChooserAsync(new WaitForOptions`
`53`	`53`	`{`
`54`	`54`	`Timeout = 1`
`55`	`55`	`}));`
`@@ -68,7 +68,7 @@ public void ShouldRespectTimeoutWhenThereIsNoCustomTimeout()`
`68`	`68`	`public void ShouldPrioritizeExactTimeoutOverDefaultTimeout()`
`69`	`69`	`{`
`70`	`70`	`Page.DefaultTimeout = 0;`
`71`		`- Assert.ThrowsAsync<TimeoutException>(() => Page.WaitForFileChooserAsync(new WaitTimeoutOptions`
	`71`	`+ Assert.ThrowsAsync<TimeoutException>(() => Page.WaitForFileChooserAsync(new WaitForOptions`
`72`	`72`	`{`
`73`	`73`	`Timeout = 1`
`74`	`74`	`}));`
`@@ -78,7 +78,7 @@ public void ShouldPrioritizeExactTimeoutOverDefaultTimeout()`
`78`	`78`	`[Skip(SkipAttribute.Targets.Firefox)]`
`79`	`79`	`public async Task ShouldWorkWithNoTimeout()`
`80`	`80`	`{`
`81`		`- var waitForTask = Page.WaitForFileChooserAsync(new WaitTimeoutOptions { Timeout = 0 });`
	`81`	`+ var waitForTask = Page.WaitForFileChooserAsync(new WaitForOptions { Timeout = 0 });`
`82`	`82`
`83`	`83`	`await Task.WhenAll(`
`84`	`84`	`waitForTask,`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public async Task ShouldRespectTimeout()`
`50`	`50`	`{`
`51`	`51`	`await Page.GoToAsync(TestConstants.EmptyPage);`
`52`	`52`	`var exception = Assert.ThrowsAsync<TimeoutException>(async () =>`
`53`		`- await Page.WaitForRequestAsync(_ => false, new WaitTimeoutOptions(1)));`
	`53`	`+ await Page.WaitForRequestAsync(_ => false, new WaitForOptions(1)));`
`54`	`54`
`55`	`55`	`StringAssert.Contains("Timeout of 1 ms exceeded", exception.Message);`
`56`	`56`	`}`
`@@ -72,7 +72,7 @@ public async Task ShouldRespectDefaultTimeout()`
`72`	`72`	`public async Task ShouldWorkWithNoTimeout()`
`73`	`73`	`{`
`74`	`74`	`await Page.GoToAsync(TestConstants.EmptyPage);`
`75`		`- var task = Page.WaitForRequestAsync(TestConstants.ServerUrl + "/digits/2.png", new WaitTimeoutOptions(0));`
	`75`	`+ var task = Page.WaitForRequestAsync(TestConstants.ServerUrl + "/digits/2.png", new WaitForOptions(0));`
`76`	`76`
`77`	`77`	`await Task.WhenAll(`
`78`	`78`	`task,`
Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ public async Task ShouldRespectTimeout()`
`77`	`77`	`{`
`78`	`78`	`await Page.GoToAsync(TestConstants.EmptyPage);`
`79`	`79`	`var exception = Assert.ThrowsAsync<TimeoutException>(async () =>`
`80`		`- await Page.WaitForResponseAsync(_ => false, new WaitTimeoutOptions(1)));`
	`80`	`+ await Page.WaitForResponseAsync(_ => false, new WaitForOptions(1)));`
`81`	`81`
`82`	`82`	`StringAssert.Contains("Timeout of 1 ms exceeded", exception.Message);`
`83`	`83`	`}`
`@@ -99,7 +99,7 @@ public async Task ShouldRespectDefaultTimeout()`
`99`	`99`	`public async Task ShouldWorkWithNoTimeout()`
`100`	`100`	`{`
`101`	`101`	`await Page.GoToAsync(TestConstants.EmptyPage);`
`102`		`- var task = Page.WaitForResponseAsync(TestConstants.ServerUrl + "/digits/2.png", new WaitTimeoutOptions(0));`
	`102`	`+ var task = Page.WaitForResponseAsync(TestConstants.ServerUrl + "/digits/2.png", new WaitForOptions(0));`
`103`	`103`
`104`	`104`	`await Task.WhenAll(`
`105`	`105`	`task,`
Original file line number	Diff line number	Diff line change
`@@ -199,7 +199,7 @@ public void Disconnect()`
`199`	`199`	`public Task CloseAsync() => _closeTask ?? (_closeTask = CloseCoreAsync());`
`200`	`200`
`201`	`201`	`/// <inheritdoc/>`
`202`		`- public async Task<ITarget> WaitForTargetAsync(Func<ITarget, bool> predicate, WaitTimeoutOptions options = null)`
	`202`	`+ public async Task<ITarget> WaitForTargetAsync(Func<ITarget, bool> predicate, WaitForOptions options = null)`
`203`	`203`	`{`
`204`	`204`	`if (predicate == null)`
`205`	`205`	`{`
Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ public Task SelectAsync(DeviceRequestPromptDevice device)`
`84`	`84`	`/// <param name="filter">The filter to apply.</param>`
`85`	`85`	`/// <param name="options">The options.</param>`
`86`	`86`	`/// <returns>A task that resolves to the first device matching the filter.</returns>`
`87`		`- public Task<DeviceRequestPromptDevice> WaitForDeviceAsync(Func<DeviceRequestPromptDevice, bool> filter, WaitTimeoutOptions options = default)`
	`87`	`+ public Task<DeviceRequestPromptDevice> WaitForDeviceAsync(Func<DeviceRequestPromptDevice, bool> filter, WaitForOptions options = default)`
`88`	`88`	`{`
`89`	`89`	`foreach (var device in Devices.Where(filter))`
`90`	`90`	`{`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ internal DeviceRequestPromptManager(ICDPSession client, TimeoutSettings timeoutS`
`40`	`40`	`_client.MessageReceived += OnMessageReceived;`
`41`	`41`	`}`
`42`	`42`
`43`		`- public async Task<DeviceRequestPrompt> WaitForDevicePromptAsync(WaitTimeoutOptions options = default)`
	`43`	`+ public async Task<DeviceRequestPrompt> WaitForDevicePromptAsync(WaitForOptions options = default)`
`44`	`44`	`{`
`45`	`45`	`if (_client == null)`
`46`	`46`	`{`