Remove globals #20
Merged
Remove globals #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And of course, the server implementation will be in pacakge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all of the command related functionality into cmd/captain and makes package captain a more re-usable library.
Primarily, these changes were made:
harbur/captain/captainwas moved to packageharbur/captain.cmd/captain/cmd.goOptionstype was moved tocmd/captainand the globaloptionsvariable was removed.I'm planning on adding an http.Handler implementation that consumes the captain package to handle GitHub push webhooks, so you can use captain as your build system both locally, and on git pushes to github without needing to setup something like jenkins. I think it could be pretty nice.
I'll submit that change upstream when it's ready and if you want it, but I figure you might also want this change.