-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React-confirm using really old react dependency #13
Comments
Yeah, I'm using it with React 16 and it works without issue (really great project, by the way, @haradakunihiko!). Should be a simple matter of incrementing the peerDependency to |
Thanks for using react-confirm. I'd really like to modify and also update the example to use the latest React version, but currently have no time for this. |
Sent a quick PR that adds the peer dependency update, and changes the example in the README to use I just saw that there are also a couple example apps, which I realize now is probably what you meant by "update the example", but I'm afraid I don't quite have time for that. FWIW, I don't believe anything else needs to change other than moving |
Thanks for the PR, your comment was helpful since I haven't used react for a while. |
Used react dependency is really old, and leads to problems with shrinkwrap, basically it can't be used when using new react versions.
The text was updated successfully, but these errors were encountered: