Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qs performing deep parsing of object instead of just top level keys #1859

Closed
leore opened this issue Aug 14, 2014 · 3 comments
Closed

qs performing deep parsing of object instead of just top level keys #1859

leore opened this issue Aug 14, 2014 · 3 comments
Assignees
Labels
bug Bug or defect

Comments

@leore
Copy link

leore commented Aug 14, 2014

We just upgraded to 6.5.1 and are having problems with hapi parsing files into buffers. Specifically for files that are part of inputs that are arrays.

For the following Multi Part Upload Payload. The "file" parameter is parsed correctly to a buffer but the "object[file]" is not parsed correctly.

POST /jobs HTTP/1.1
Host: v1
Authorization: Basic dGVzdF83MDczMTFjOGY0OTM2NmJhZTA1YWQ0OWEwMDZjN2M4NTJjNjo=
Cache-Control: no-cache
Postman-Token: ee6ac88f-e9a8-5893-95d9-0eebfdd3b61b
Content-Type: multipart/form-data; boundary=----WebKitFormBoundaryp7MA4YWxkTrZu0gW

----WebKitFormBoundaryE19zNvXGzXaLvS5C
Content-Disposition: form-data; name="name"

73071
----WebKitFormBoundaryE19zNvXGzXaLvS5C
Content-Disposition: form-data; name="object[file]"; filename="KunversionLeadGenExample.pdf"
Content-Type: application/pdf


----WebKitFormBoundaryE19zNvXGzXaLvS5C
Content-Disposition: form-data; name="file"; filename="KunversionLeadGenExample.pdf"
Content-Type: application/pdf


----WebKitFormBoundaryE19zNvXGzXaLvS5C
@hueniverse
Copy link
Contributor

This is a bug in the qs module. See ljharb/qs#17

@hueniverse hueniverse added the bug label Aug 14, 2014
@hueniverse hueniverse changed the title Bug in 6.5.1 qs performing deep parsing of object instead of just top level keys Aug 14, 2014
@hueniverse hueniverse self-assigned this Aug 14, 2014
@hueniverse
Copy link
Contributor

Try upgrading to qa 1.2.2 and let me know if the issue is resolved.

@hueniverse
Copy link
Contributor

Should be fixed now. Please confirm.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug or defect
Projects
None yet
Development

No branches or pull requests

2 participants