perf(Server): improve request handle performance

Author: hans00

packages/server/js/response.js

@@ -6,6 +6,7 @@ const mime = require('mime-types')
 const { Writable } = require('stream')
 const parseRange = require('range-parser')
 const { keepHeaderCase } = require('./constants')
+const httpStatusCode = require('./status')
 
 const staticPath = path.resolve(process.cwd(), 'static')
 
@@ -22,52 +23,6 @@ const hContentRange = 'Content-Range'
 const hLastModified = 'Last-Modified'
 const hCacheControl = 'Cache-Control'
 
-const httpStatusCode = {
-  // Informational
-  100: 'Continue',
-  101: 'Switching Protocols',
-  // Successful
-  200: 'OK',
-  201: 'Created',
-  202: 'Accepted',
-  203: 'Non-Authoritative Information',
-  204: 'No Content',
-  205: 'Reset Content',
-  206: 'Partial Content',
-  // Redirection
-  300: 'Multiple Choices',
-  301: 'Moved Permanently',
-  302: 'Found',
-  303: 'See Other',
-  304: 'Not Modified',
-  305: 'Use Proxy',
-  307: 'Temporary Redirect',
-  // Client Error
-  400: 'Bad Request',
-  401: 'Unauthorized',
-  402: 'Payment Required',
-  403: 'Forbidden',
-  404: 'Not Found',
-  405: 'Method Not Allowed',
-  406: 'Not Acceptable',
-  408: 'Request Timeout',
-  409: 'Conflict',
-  410: 'Gone',
-  411: 'Length Required',
-  412: 'Precondition Failed',
-  413: 'Request Entity Too Large',
-  414: 'Request-URI Too Long',
-  415: 'Unsupported Media Type',
-  416: 'Requested Range Not Satisfiable',
-  417: 'Expectation Failed',
-  418: 'I\'m a teapot',
-  // Server Error
-  500: 'Internal Server Error',
-  501: 'Not Implemented',
-  502: 'Bad Gateway',
-  503: 'Service Unavailable'
-}
-
 class Response extends Writable {
   constructor (connection) {
     super()

packages/server/js/routes.js

@@ -5,6 +5,31 @@ const WebSocketResponse = require('./websocket')
 const Connection = require('./connection')
 const ServerError = require('./errors')
 
+async function handler (params, callbacks, response, request) {
+  const paramsMap = {}
+  if (params) {
+    params.forEach((key, index) => {
+      paramsMap[key] = decodeURIComponent(request.getParameter(index))
+    })
+  }
+  const conn = Connection.create(this, request, response)
+  const req = Request.create(conn)
+  const res = Response.create(conn)
+  try {
+    conn.processBodyData()
+    await callbacks(req, res, paramsMap)
+  } catch (e) {
+    this.log.error('Server Internal Error', e)
+    if (!res._writableState.destroyed) {
+      if (e instanceof ServerError && e.httpCode) {
+        res.status(e.httpCode).end(e.message)
+      } else {
+        res.status(500).end('Server Internal Error')
+      }
+    }
+  }
+}
+
 class Routes {
   constructor () {
     this._routes = {}
@@ -24,51 +49,25 @@ class Routes {
 
   route (method, path, callbacks) {
     if (this.lock) {
-      throw new ServerError({
-        code: 'SERVER_ALREADY_STARTED',
-        message: 'Cannot add route after sterver started.'
-      })
+      throw new Error('The server is started, should not add route.')
+    }
+    if (typeof path !== 'string' && !path.startsWith('/')) {
+      throw new TypeError('Route path whould starts with "/".')
     }
     if (!this._routes[path]) {
       this._routes[path] = {}
     }
     if (this._routes[path][method]) {
-      throw new ServerError({
-        code: 'INVALID_DUPLICATE_ROUTER',
-        message: 'Invalid, duplicated router.'
-      })
+      throw new Error(`${method.toUpperCase()} "${path}" is exists.`)
     }
     if (method === 'ws') {
       this._routes[path][method] = callbacks
     } else {
-      let URLParams = path.match(/:\w+/g)
-      if (URLParams) {
-        URLParams = URLParams.map(key => key.slice(1))
-      }
-      this._routes[path][method] = async (response, request) => {
-        const params = {}
-        if (URLParams) {
-          URLParams.forEach((key, index) => {
-            params[key] = decodeURIComponent(request.getParameter(index))
-          })
-        }
-        const conn = Connection.create(this, request, response)
-        const req = Request.create(conn)
-        const res = Response.create(conn)
-        try {
-          conn.processBodyData()
-          await callbacks(req, res, params)
-        } catch (e) {
-          this.log.error('Server Internal Error', e)
-          if (!res._writableState.destroyed) {
-            if (e instanceof ServerError && e.httpCode) {
-              res.status(e.httpCode).end(e.message)
-            } else {
-              res.status(500).end('Server Internal Error')
-            }
-          }
-        }
+      let params = path.match(/:\w+/g)
+      if (params) {
+        params = params.map(key => key.slice(1))
       }
+      this._routes[path][method] = handler.bind(this, params, callbacks)
     }
   }
 

packages/server/js/status.js

@@ -0,0 +1,45 @@
+module.exports = {
+  // Informational
+  100: 'Continue',
+  101: 'Switching Protocols',
+  // Successful
+  200: 'OK',
+  201: 'Created',
+  202: 'Accepted',
+  203: 'Non-Authoritative Information',
+  204: 'No Content',
+  205: 'Reset Content',
+  206: 'Partial Content',
+  // Redirection
+  300: 'Multiple Choices',
+  301: 'Moved Permanently',
+  302: 'Found',
+  303: 'See Other',
+  304: 'Not Modified',
+  305: 'Use Proxy',
+  307: 'Temporary Redirect',
+  // Client Error
+  400: 'Bad Request',
+  401: 'Unauthorized',
+  402: 'Payment Required',
+  403: 'Forbidden',
+  404: 'Not Found',
+  405: 'Method Not Allowed',
+  406: 'Not Acceptable',
+  408: 'Request Timeout',
+  409: 'Conflict',
+  410: 'Gone',
+  411: 'Length Required',
+  412: 'Precondition Failed',
+  413: 'Request Entity Too Large',
+  414: 'Request-URI Too Long',
+  415: 'Unsupported Media Type',
+  416: 'Requested Range Not Satisfiable',
+  417: 'Expectation Failed',
+  418: 'I\'m a teapot',
+  // Server Error
+  500: 'Internal Server Error',
+  501: 'Not Implemented',
+  502: 'Bad Gateway',
+  503: 'Service Unavailable'
+}