Misc improvements #24
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
force-pushed
the
misc-improvements
branch
from
c7db8c7 to
8a2663e
Compare
hannesm
reviewed
Jun 4, 2025
| if Lib.List.last hunk.mine = (Lib.List.last hunk.their : string) then | ||
| let rev_mine = List.rev hunk.mine in | ||
| let rev_their = List.rev hunk.their in | ||
| if List.hd rev_mine = (List.hd rev_their : string) then |
Owner
There was a problem hiding this comment.
Can we use String.equal explicitly here to avoid the potential polymorphic compare? I understand that the : string should enable the OCaml compiler to use the right function, but I prefer to be explicit.
Owner
|
this looks fine to me, feel free to merge when you're ready. |
…two sets of numbers
kit-ty-kate
force-pushed
the
misc-improvements
branch
from
8a2663e to
54bc35c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queued on #23