Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define the importable files through exports property in package.json #1144

Open
sequba opened this issue Jan 13, 2023 · 0 comments
Open

Define the importable files through exports property in package.json #1144

sequba opened this issue Jan 13, 2023 · 0 comments
Assignees
@sequba
Labels
Breaking Change Will need a major release Feature Something we can add later on without introducing a breaking change Impact: Low

Comments

@sequba
Copy link
Contributor

sequba commented Jan 13, 2023 •
edited
Loading

Description

Publint reports for all files in /es/ directory:

pkg.module is used to output ESM, but pkg.exports is not defined. As NodeJS doesn't read pkg.module, the ESM output may be skipped. Consider adding pkg.exports to export the ESM output. pkg.module can usually be removed alongside too. (This will be a breaking change)

We can fix it by adding the exports property to package.json.

It should probably be done together with #1086

Warning: this change might be considered breaking.

HOT team did a similar task in handsontable/handsontable#7403 & https://github.com/handsontable/handsontable/pull/8875/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

Links
@sequba sequba added Feature Something we can add later on without introducing a breaking change Breaking Change Will need a major release Impact: Low labels Jan 13, 2023
@sequba sequba self-assigned this Jan 13, 2023
@sequba sequba mentioned this issue Jan 13, 2023
Open
@sequba sequba mentioned this issue Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sequba sequba

Labels
Breaking Change Will need a major release Feature Something we can add later on without introducing a breaking change Impact: Low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sequba