Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make testing for heroku appname duplication available when tyr is a library #213

Open
clarkerican opened this issue Apr 7, 2018 · 1 comment

Comments

@clarkerican
Copy link

Using tyr as a library runs into complications when the chosen name is duplicated or has uppercase/dashes. All the checks for the name should take place before the docker file is created so the docker file knows the correct herokuapp name. To solve this, we can make the function that validates the heroku app name available to the public.

@clarkerican
Copy link
Author

Looked into this, it is not as easy as it sounds. The Heroku appname is validated during project creation on Heroku. The project creation on Endor may have to be refactored to account for this.
A couple options that I though of:

  • Wait for all the files to be generated and the user waits while there is a spinner on the screen
  • Bring the user to the project page, and when the files are ready, they can click a button to download them. (This may involve some sort of mechanism to indicate that the files are done.)

@clarkerican clarkerican removed their assignment Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant