Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix licence and add correct SPDX licence identifier #414

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

tumbarumba
Copy link
Member

  • Moved LICENSE.txt to the more standard LICENCE, ensuring the text is the same as the canonical version at https://opensource.org/license/BSD-3-Clause
  • Used the correct SPDX license identifier in the Bundle-License field in the manifest, as well as the pom
  • Used the correct SPDX license identifier in the pom

Closes #264, Closes #355, Closes #399

@tumbarumba tumbarumba merged commit ad5c9f2 into hamcrest:master Jul 23, 2024
2 checks passed
@tumbarumba tumbarumba deleted the license-fix branch July 23, 2024 06:15
@vlsi
Copy link
Contributor

vlsi commented Jul 23, 2024

Thanks for looking into this.

I'm afraid the PR does not fix the core of #264.

See the second clause of the license:

  1. Redistributions in binary form must reproduce the above copyright notice

Imagine somebody redistributes hamcreset.jar or includes it in their application. The license forces them to include the copyright notice, however, the release jars on Maven Central do not include the full license text. How would they know which exact license text (==copyright notice) matches every Hamcrest release?

See https://github.com/hamcrest/JavaHamcrest/pull/399/files#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7R75-R77

The link https://opensource.org/license/BSD-3-Clause points to a license template rather than a canonical text. Please make the link point to the license text, and and please include the license text as META-INF/LICENSE to make it easier for the consumers to comply with the license.

@tumbarumba
Copy link
Member Author

Thanks for looking at this @vlsi. I'll make the suggested changes in the next few days

@tumbarumba
Copy link
Member Author

Fix merged. @vlsi, can you please check?

ndwlocatieservices added a commit to ndwnu/nls-routing-map-matcher that referenced this pull request Oct 14, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [org.hamcrest:hamcrest-library](http://hamcrest.org/JavaHamcrest/) ([source](https://github.com/hamcrest/JavaHamcrest)) | test | major | `2.2` -> `3.0` |

---

### Release Notes

<details>
<summary>hamcrest/JavaHamcrest (org.hamcrest:hamcrest-library)</summary>

### [`v3.0`](https://github.com/hamcrest/JavaHamcrest/blob/HEAD/CHANGES.md#Version-30-1st-August-2024)

[Compare Source](hamcrest/JavaHamcrest@v2.2...v3.0)

##### Breaking Changes

-   From version 3.0, the jar distributed to Maven Central is now compiled to Java 1.8 bytecode,
    and is not compatible with previous versions of Java. See
    [Issue #&#8203;331](hamcrest/JavaHamcrest#331) and
    [PR #&#8203;411](hamcrest/JavaHamcrest#411) for details. Developers who use Java 1.7 earlier can still
    depend upon `hamcrest-2.2.jar`.

##### Improvements

-   FileMatchersTest simplification ([PR #&#8203;389](hamcrest/JavaHamcrest#389))
-   License cleanup ([PR #&#8203;414](hamcrest/JavaHamcrest#414),
    [PR #&#8203;415](hamcrest/JavaHamcrest#415), see also
    [#&#8203;264](hamcrest/JavaHamcrest#264),
    [#&#8203;355](hamcrest/JavaHamcrest#355),
    [#&#8203;396](hamcrest/JavaHamcrest#396
    [#&#8203;399](hamcrest/JavaHamcrest#399))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or rename PR to start with "rebase!".

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflicting license declarations Please add LICENSE as META-INF/LICENSE, add Bundle-License header
2 participants