-
-
Notifications
You must be signed in to change notification settings - Fork 73
Add support for PHP 8.5 #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Made a change to fix the tests. |
|
Thanks for participating. It's been some busy days for me, sorry. Try |
|
No dramas. Docker and Xdebug are new to me I'm sort of stabbing in the dark here. |
|
The big advantage of running locally is way faster runtime because the docker images are cached. I'm afraid, that the problem is somewhere else than in the xdebug version. |
|
If it's the case, and I believe it is, that the tests are broken but not the actual application, would you consider accepting this PR? I only using json-machine during import, so I can revert to PHP 8.4 when importing if there really is a problem. Right now, I can't test my app with PHP 8.5 because of this bundle. Thanks for your consideration. I'd rather have it installable and possibly broken than not installable. |
|
I think 8.5 in docker is failing because Derick (xdebug author) is not uploading it to pecl (not for the next few weeks at least to to encourage migration to pie). Moving away from pecl toward pie looks like a solution here |
|
see #129 |
|
I fixed some minimal PHP/xdebug interop problems by updating xdebug to add support for PHP 8.5. Xdebug is now also not mandatory for the build process (which means no waiting for support of PHP pre-releases.) |
This allows the package to be installed with PHP 8.5.