Skip to content

Conversation

@dwightwatson
Copy link

This allows the package to be installed with PHP 8.5.

@dwightwatson
Copy link
Author

Made a change to fix the tests.

@halaxa
Copy link
Owner

halaxa commented Nov 27, 2025

Thanks for participating. It's been some busy days for me, sorry. Try make build locally. It makes the exact build as github actions. If there are still problems I'll look into in in few days.

@dwightwatson
Copy link
Author

No dramas. Docker and Xdebug are new to me I'm sort of stabbing in the dark here.

@halaxa
Copy link
Owner

halaxa commented Nov 27, 2025

The big advantage of running locally is way faster runtime because the docker images are cached. I'm afraid, that the problem is somewhere else than in the xdebug version.

@tacman
Copy link

tacman commented Nov 30, 2025

If it's the case, and I believe it is, that the tests are broken but not the actual application, would you consider accepting this PR?

I only using json-machine during import, so I can revert to PHP 8.4 when importing if there really is a problem. Right now, I can't test my app with PHP 8.5 because of this bundle.

Thanks for your consideration. I'd rather have it installable and possibly broken than not installable.

@norberttech
Copy link

I think 8.5 in docker is failing because Derick (xdebug author) is not uploading it to pecl (not for the next few weeks at least to to encourage migration to pie).

Moving away from pecl toward pie looks like a solution here

@nikow13
Copy link

nikow13 commented Dec 5, 2025

see #129

@halaxa halaxa closed this in 0445588 Dec 5, 2025
@halaxa
Copy link
Owner

halaxa commented Dec 5, 2025

I fixed some minimal PHP/xdebug interop problems by updating xdebug to add support for PHP 8.5. Xdebug is now also not mandatory for the build process (which means no waiting for support of PHP pre-releases.)

@halaxa halaxa mentioned this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants