Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

button.ladda( 'isLoading' ) returns button object instead of loading state #65

Closed
diesl opened this issue Aug 7, 2017 · 3 comments
Closed

Comments

@diesl
Copy link

diesl commented Aug 7, 2017

When using the jquery version of your script, isLoading returns the button object instead of a boolean loading state value. The normal javascript version works just fine.

Reproduce with:

// Create a new instance of ladda for the specified button
var l = $( '.my-button' ).ladda();

// Check the current state
l.ladda( 'isLoading' );
@theodorejb
Copy link
Collaborator

The jQuery portion of this library is no longer being maintained, and the plan is to remove it in the next major version of Ladda. I recommend that you use the normal JavaScript API instead.

@diesl
Copy link
Author

diesl commented Aug 14, 2017

Thank you for the information!

The jQuery portion of this library is no longer being maintained, and the plan is to remove it in the next major version of Ladda.

If it is not maintained, you should at least mention in the documentation that this particular method does not work, mark the jQuery part of the documentation as unmaintained or remove it completely so people will use the normal API right away.

@diesl
Copy link
Author

diesl commented Aug 28, 2017

Thanks for the fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants