Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash64/hash128/hash_bytes(..., x64arch = False) fail on s390x #52

Closed
hajimes opened this issue Jan 3, 2024 · 1 comment
Closed

hash64/hash128/hash_bytes(..., x64arch = False) fail on s390x #52

hajimes opened this issue Jan 3, 2024 · 1 comment
Assignees
Labels

Comments

@hajimes
Copy link
Owner

hajimes commented Jan 3, 2024

Test cases for the functions hash64/hash128/hash_bytes fail on s390x when the arg x64arch is False (https://github.com/hajimes/mmh3/actions/runs/7396371609), likely because the architecture is big-endian.

  >       assert mmh3.hash64("foo", signed=False, x64arch=False) == (
              6968798590592097061,
              6968798590746895717,
          )
  E       assert (630394342576...8590746895717) == (696879859059...8590746895717)
  E         At index 0 diff: 6303943425762141541 != 6968798590592097061
  E         Use -v to get more diff

The result should be the same as the value in little-endian environments (feature from 4.0.0).

@hajimes hajimes self-assigned this Jan 3, 2024
@hajimes hajimes added the bug label Jan 3, 2024
@hajimes
Copy link
Owner Author

hajimes commented Jan 9, 2024

Done in version 4.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant