Make sure files end with exactly one new line and police this in presubmit.

The changes are (excluding presubmit.py) mechanical. I added the following
lines after the check and iterated the presubmit script until all errors
went away:

f = open(name, "w");
if contents.endswith('\n\n'):
  f.write(contents[0:-1])
else:
  f.write(contents + '\n')

[email protected]

Review URL: https://codereview.chromium.org/82803005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@18017 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

Author: [email protected]

build/all.gyp

@@ -22,4 +22,3 @@
     }
   ]
 }
-

src/allocation-tracker.h

@@ -135,4 +135,3 @@ class AllocationTracker {
 } }  // namespace v8::internal
 
 #endif  // V8_ALLOCATION_TRACKER_H_
-

src/arraybuffer.js

@@ -107,5 +107,3 @@ function SetUpArrayBuffer() {
 }
 
 SetUpArrayBuffer();
-
-

src/checks.cc

@@ -132,4 +132,3 @@ namespace v8 { namespace internal {
   intptr_t HeapObjectTagMask() { return kHeapObjectTagMask; }
 
 } }  // namespace v8::internal
-

src/harmony-array.js

@@ -121,4 +121,4 @@ function HarmonyArrayExtendArrayPrototype() {
   ));
 }
 
-HarmonyArrayExtendArrayPrototype();
+HarmonyArrayExtendArrayPrototype();

src/harmony-string.js

@@ -151,4 +151,4 @@ function ExtendStringPrototype() {
   ));
 }
 
-ExtendStringPrototype();
+ExtendStringPrototype();

src/heap-snapshot-generator-inl.h

@@ -85,4 +85,3 @@ int V8HeapExplorer::GetGcSubrootOrder(HeapObject* subroot) {
 } }  // namespace v8::internal
 
 #endif  // V8_HEAP_SNAPSHOT_GENERATOR_INL_H_
-

src/heap-snapshot-generator.h

@@ -704,4 +704,3 @@ class HeapSnapshotJSONSerializer {
 } }  // namespace v8::internal
 
 #endif  // V8_HEAP_SNAPSHOT_GENERATOR_H_
-

src/ia32/simulator-ia32.cc

@@ -27,4 +27,3 @@
 
 
 // Since there is no simulator for the ia32 architecture this file is empty.
-

src/x64/simulator-x64.cc

@@ -24,4 +24,3 @@
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-

test/cctest/test-unbound-queue.cc

@@ -74,4 +74,3 @@ TEST(MultipleRecords) {
   }
   CHECK(cq.IsEmpty());
 }
-

test/cctest/test-unique.cc

@@ -546,4 +546,3 @@ TEST(UniqueSet_UnionExhaustive) {
     }
   }
 }
-

test/intl/collator/sr-sort.js

@@ -43,4 +43,3 @@ assertEquals('Стара Планина', result[6]);
 assertEquals('ћук', result[7]);
 assertEquals('чука', result[8]);
 assertEquals('џак', result[9]);
-

test/intl/overrides/caching.js

@@ -57,4 +57,3 @@ collatorTime = endTime.getTime() - startTime.getTime();
 assertTrue(collatorTime < cachedTime);
 // Non-cached time is much slower, measured to 12.5 times.
 assertTrue(cachedTime < nonCachedTime);
-

test/message/isvar.js

@@ -28,4 +28,4 @@
 // Flags: --allow-natives-syntax
 var x;
 %IS_VAR(x);
-%IS_VAR(x+x);
+%IS_VAR(x+x);

test/message/paren_in_arg_string.js

@@ -26,4 +26,4 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 var paren_in_arg_string_good = new Function('x', 'return;');
-var paren_in_arg_string_bad = new Function(')', 'return;');
+var paren_in_arg_string_bad = new Function(')', 'return;');

test/message/replacement-marker-as-argument.js

@@ -28,4 +28,4 @@
 "use strict";
 
 var o = { get "%3" (){} };
-o["%3"] = 10;
+o["%3"] = 10;

test/message/single-function-literal.js

@@ -29,4 +29,4 @@
 var single_function_good = "(function() { return 5; })";
 %CompileString(single_function_good, true);
 var single_function_bad = "(function() { return 5; })();";
-%CompileString(single_function_bad, true);
+%CompileString(single_function_bad, true);

test/mjsunit/arguments-load-across-eval.js

@@ -82,5 +82,3 @@ function testShadowing(x, h) {
 }
 
 testShadowing(1, function() { return 2; });
-
-

test/mjsunit/arguments-read-and-assignment.js

@@ -161,4 +161,4 @@ function weirdargs(a,b,c) { if (!a) return arguments;
 var args1 = weirdargs(false, null, 40);
 var res = weirdargs(true, args1, 15);
 assertEquals(40, res[0], "return old args element");
-assertEquals(15, res[1], "return own args element");
+assertEquals(15, res[1], "return own args element");

test/mjsunit/arguments.js

@@ -187,4 +187,4 @@ function arg_del(x) { return delete arguments[x]; }
 function arg_set(x) { return (arguments[x] = 117); }
 assertEquals(undefined, arg_get(0xFFFFFFFF));
 assertEquals(true, arg_del(0xFFFFFFFF));
-assertEquals(117, arg_set(0xFFFFFFFF));
+assertEquals(117, arg_set(0xFFFFFFFF));

test/mjsunit/array-iteration.js

@@ -225,4 +225,3 @@
   assertEquals(2, count);
 
 })();
-

test/mjsunit/array-non-smi-length.js

@@ -43,4 +43,3 @@ function TestNonSmiArrayLength() {
 }
 
 TestNonSmiArrayLength();
-

test/mjsunit/array-tostring.js

@@ -156,4 +156,4 @@ for (var i = 0; i < 3; i++) {
       }});
 }
 Number.prototype.arrayToLocaleString = Array.prototype.toLocaleString;
-assertEquals("42,42,42", (42).arrayToLocaleString());
+assertEquals("42,42,42", (42).arrayToLocaleString());

test/mjsunit/bugs/bug-1344252.js

@@ -76,4 +76,3 @@ Object.prototype.__defineSetter__('z', function(value) { result_z = value; });
 o2.z = 27;
 assertEquals(27, result_z);
 assertTrue(typeof o2.z == 'undefined');
-

test/mjsunit/bugs/bug-proto.js

@@ -59,4 +59,3 @@ assertSame(undefined, Realm.eval(realmB, "Realm.shared.__proto__"));
 Realm.eval(realmB, "Realm.shared.__proto__ = {c: 3}");
 assertSame(1, o.a);
 assertSame(undefined, o.c);
-

test/mjsunit/closures.js

@@ -44,4 +44,3 @@ function test(n) {
 test(1);
 test(42);
 test(239);
-

test/mjsunit/compare-character.js

@@ -47,4 +47,3 @@ for (var i in a) {
   assertEquals(f < x, 'f' < x, ">r" + x);
   assertEquals(f <= x, 'f' <= x, ">=r" + x);
 }
-

test/mjsunit/compare-nan.js

@@ -63,4 +63,3 @@ for (var i in b) {
       "assertFalse(" + x + " >= NaN, '' + " + x + " + ' >= NaN');\n";
   eval(program);
 }
-

test/mjsunit/compiler/control-flow-1.js

@@ -52,4 +52,4 @@ function g1(x, y) {
 }
 
 assertTrue(g1(0, 0));
-assertFalse(g1(0, 1));
+assertFalse(g1(0, 1));

test/mjsunit/compiler/inline-throw.js

@@ -66,4 +66,3 @@ try {
 } catch(e) {
   assertEquals("wow", e);
 }
-

test/mjsunit/compiler/lazy-const-lookup.js

@@ -38,4 +38,3 @@ function outer() {
 }
 
 outer();
-

test/mjsunit/compiler/optimized-closures.js

@@ -51,7 +51,3 @@ f();
 assertEquals(42, a[0]);
 assertEquals(49, a[7]);
 assertEquals(-19, a[23]);
-
-
-
-

test/mjsunit/compiler/regress-1394.js

@@ -56,4 +56,3 @@ for (var i = 0; i < 3; i++) assertEquals(i, f(i));
 
 assertEquals(0, f(0));
 assertEquals(1, f(1));
-

test/mjsunit/compiler/regress-3260426.js

@@ -33,4 +33,3 @@ function always_false() {}
 function test() { return always_false() ? 0 : 1; }
 
 assertEquals(1, test());
-

test/mjsunit/compiler/regress-closures-with-eval.js

@@ -53,4 +53,4 @@ for (var n = 0; n < 5; n++) {
   withEval(expr, function(a) { return a; });
 }
 %OptimizeFunctionOnNextCall(withEval);
-withEval(expr, function(a) { return a; });
+withEval(expr, function(a) { return a; });

test/mjsunit/compiler/regress-inline-callfunctionstub.js

@@ -43,4 +43,3 @@ main(o.g);
 main(o.g);
 %OptimizeFunctionOnNextCall(main);
 main(o.g);
-

test/mjsunit/compiler/regress-toint32.js

@@ -42,4 +42,3 @@ assertEquals(G, f(G));
 assertEquals(G, f(G));
 %OptimizeFunctionOnNextCall(f);
 assertEquals(G, f(G));
-

test/mjsunit/compiler/rotate.js

@@ -306,5 +306,3 @@ assertEquals(ROR4(0xFFFFFFFF, 40), ROR4_sa40(0xFFFFFFFF));
 assertEquals(ROR4(0xFFFFFFFF, 40), ROR4_sa40(0xFFFFFFFF));
 %OptimizeFunctionOnNextCall(ROR4_sa40);
 assertEquals(ROR4(0xFFFFFFFF, 40), ROR4_sa40(0xFFFFFFFF));
-
-

test/mjsunit/const-declaration.js

@@ -169,4 +169,3 @@
   }
   f("const x = 0;");
 })();
-

test/mjsunit/cyclic-array-to-string.js

@@ -62,4 +62,3 @@ a1.push(a2);
 assertEquals("", a1.toString());
 assertEquals("", a1.toLocaleString());
 assertEquals("", a1.join());
-

test/mjsunit/debug-breakpoints.js

@@ -222,4 +222,3 @@ for(var i = 0; i < scenario.length; i++) {
       Debug.BreakPositionAlignment.BreakPosition).indexOf(scenario[i][1]) > 0);
   Debug.clearBreakPoint(bp1);
 }
-

test/mjsunit/debug-constructor.js

@@ -75,4 +75,4 @@ Debug.clearStepping();  // Clear stepping as the listener leaves it on.
 assertEquals("bbccdcb", call_graph);
 
 // Get rid of the debug event listener.
-Debug.setListener(null);
+Debug.setListener(null);

test/mjsunit/debug-evaluate-const.js

@@ -118,4 +118,3 @@ Debug.setListener(null);
 
 assertFalse(exception, "exception in listener")
 assertTrue(listenerComplete);
-

test/mjsunit/debug-function-scopes.js

@@ -159,4 +159,3 @@ CheckNoScopeVisible(Function.toString);
 
 // This getter is known to be implemented as closure.
 CheckNoScopeVisible(new Error().__lookupGetter__("stack"));
-

test/mjsunit/debug-ignore-breakpoints.js

@@ -86,4 +86,3 @@ f();
 assertEquals(5, break_point_hit_count);
 f();
 assertEquals(6, break_point_hit_count);
-

test/mjsunit/debug-liveedit-3.js

@@ -66,5 +66,3 @@ assertEquals(8, z6());
 var z100 = Factory(100)();
 
 assertEquals(102, z100());
-
-

test/mjsunit/debug-liveedit-check-stack.js

@@ -138,4 +138,3 @@ test = new TestBase("Test with C++ frame above ChooseAnimal frame");
 exception_holder = {};
 assertEquals("Cat", test.ChooseAnimal(WrapInNativeCall(WrapInDebuggerCall(WrapInCatcher(test.ScriptChanger, exception_holder)))));
 assertTrue(!!exception_holder[0]);
-

test/mjsunit/debug-liveedit-compile-error.js

@@ -56,5 +56,3 @@ assertEquals("Unexpected token )",
     caught_exception.details.syntaxErrorMessage);
 
 assertEquals(2, caught_exception.details.position.start.line);
-
-

test/mjsunit/debug-liveedit-diff.js

@@ -110,4 +110,3 @@ CheckCompare(
     "yesterday\nall\nmy\ntroubles\nseemed\nso\nfar\naway",
     "yesterday\nall\nmy\ntroubles\nseemed\nso\n"
 );
-

test/mjsunit/debug-liveedit-utils.js

@@ -93,5 +93,3 @@ assertEquals(69, MultiChunkTranslator.Translate(59));
 assertEquals(2010, MultiChunkTranslator.Translate(60, Return2010));
 assertEquals(70, MultiChunkTranslator.Translate(70));
 assertEquals(75, MultiChunkTranslator.Translate(75));
-
-

test/mjsunit/debug-mirror-cache.js

@@ -82,4 +82,3 @@ debugger;
 assertEquals([], listenerExceptions, "Exception in listener");
 // Make sure that the debug event listener vas invoked.
 assertEquals(2, listenerCallCount, "Listener not called");
-

test/mjsunit/debug-setbreakpoint.js

@@ -214,4 +214,3 @@ function SetBreakpointInI1Script() {
 // moment. Since there's no way of simply getting the pointer to the function,
 // we run this code while the script function is being activated on stack.
 eval('SetBreakpointInI1Script()\nfunction i1(){}\n\n\n\nfunction i2(){}\n');
-

test/mjsunit/debug-stepin-positions.js

@@ -221,5 +221,3 @@ var fun = (function(p) {
   };
 })(Object);
 TestCaseWithDebugger(fun);
-
-

test/mjsunit/debug-stepout-scope-part1.js

@@ -187,4 +187,4 @@ function nop() {}
 
 
 // With block as the last(!) statement in global code.
-with ({}) { debugger; }
+with ({}) { debugger; }

test/mjsunit/elide-double-hole-check-9.js

@@ -46,4 +46,3 @@ assertEquals(0.5, f(arr, 0));
 assertEquals(0.5, f(arr, 0));
 do_set = true;
 assertEquals(2, f(arr, 1));
-

test/mjsunit/enumeration-order.js

@@ -103,7 +103,3 @@ var expected = ['23', '42',  // indexed from 'o'
 var actual = [];
 for (var p in o) actual.push(p);
 assertArrayEquals(expected, actual);
-
-
-
-

test/mjsunit/error-accessors.js

@@ -51,4 +51,3 @@ assertEquals("x is not defined",
 o.message = "another message";
 assertEquals("another message", o.message);
 assertEquals("x is not defined", error2.message);
-

test/mjsunit/eval-stack-trace.js

@@ -201,4 +201,3 @@ try {
   [true, false].verifyUndefined(frames, "getFileName");
   ["eval at <anonymous> ("].verifyContains(frames, "getEvalOrigin");
 }
-

test/mjsunit/extra-arguments.js

@@ -50,5 +50,3 @@ for (var i = 0; i < 25; i++) {
   }
   assertEquals(expected, f.apply(null, array), String(i));
 }
-
-

test/mjsunit/fast-array-length.js

@@ -34,4 +34,3 @@ var a = [0, 1, 2, 3, 4, 5];
 assertTrue(%HasFastSmiElements(a));
 a.length = (1 << 30);
 assertFalse(%HasFastSmiElements(a));
-

test/mjsunit/fast-literal.js

@@ -37,6 +37,3 @@ f(); f(); f();
 for (var i=0; i<50; i++) {
   f();
 }
-
-
-

test/mjsunit/fun-name.js

@@ -31,4 +31,3 @@ function strip(s) {
 
 assertEquals('function(){}', strip((function () { }).toString()));
 assertEquals('functionanonymous(){}', strip(new Function().toString()));
-

test/mjsunit/function.js

@@ -80,4 +80,3 @@ assertEquals(42, f(2, 21));
 f = new Function(x, y, z);
 assertEquals(25, f(5, 5));
 assertEquals(42, f(2, 21));
-

test/mjsunit/get-prototype-of.js

@@ -65,4 +65,3 @@ GetPrototypeOfObject(y);
 GetPrototypeOfObject({x:5});
 GetPrototypeOfObject(F);
 GetPrototypeOfObject(RegExp);
-

test/mjsunit/getter-in-value-prototype.js

@@ -32,4 +32,3 @@
 
 String.prototype.__defineGetter__('x', function() { return this; });
 assertEquals(Object('asdf'), 'asdf'.x);
-

test/mjsunit/global-load-from-eval-in-with.js

@@ -56,4 +56,3 @@ test({ y: 42 }, "function f() { eval('1'); assertEquals(27, x) }; f();");
 // in the eval scopes.  Deeper nesting this time.
 test({ x: 42 }, "function f() { function g() { eval('1'); assertEquals(42, x) }; g() }; f();");
 test({ y: 42 }, "function f() { function g() { eval('1'); assertEquals(27, x) }; g() }; f();");
-

test/mjsunit/global-load-from-nested-eval.js

@@ -59,8 +59,3 @@ function testEvalDontShadow(source) {
   eval('eval(' + source +')');
 }
 testEvalDontShadow('assertEquals(42, x)');
-
-
-
-
-

test/mjsunit/harmony/array-find.js

@@ -277,4 +277,4 @@ assertThrows('Array.prototype.find.apply({}, false, [])', TypeError);
 assertThrows('Array.prototype.find.apply({}, "", [])', TypeError);
 assertThrows('Array.prototype.find.apply({}, {}, [])', TypeError);
 assertThrows('Array.prototype.find.apply({}, [], [])', TypeError);
-assertThrows('Array.prototype.find.apply({}, /\d+/, [])', TypeError);
+assertThrows('Array.prototype.find.apply({}, /\d+/, [])', TypeError);

test/mjsunit/harmony/array-findindex.js

@@ -277,4 +277,4 @@ assertThrows('Array.prototype.findIndex.apply({}, false, [])', TypeError);
 assertThrows('Array.prototype.findIndex.apply({}, "", [])', TypeError);
 assertThrows('Array.prototype.findIndex.apply({}, {}, [])', TypeError);
 assertThrows('Array.prototype.findIndex.apply({}, [], [])', TypeError);
-assertThrows('Array.prototype.findIndex.apply({}, /\d+/, [])', TypeError);
+assertThrows('Array.prototype.findIndex.apply({}, /\d+/, [])', TypeError);