Skip to content

Commit ba58edf

Browse files
Shorten constructor names in JS tickprocessor.
As they are no more used in DevTools profiler, there is no need to prefix them with "devtools.profiler" namespace. Review URL: http://codereview.chromium.org/6456025 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@6712 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
1 parent b7b49c6 commit ba58edf

12 files changed

+219
-249
lines changed

test/mjsunit/tools/codemap.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131

3232
function newCodeEntry(size, name) {
33-
return new devtools.profiler.CodeMap.CodeEntry(size, name);
33+
return new CodeMap.CodeEntry(size, name);
3434
};
3535

3636

@@ -47,7 +47,7 @@ function assertNoEntry(codeMap, addr) {
4747

4848

4949
(function testLibrariesAndStaticCode() {
50-
var codeMap = new devtools.profiler.CodeMap();
50+
var codeMap = new CodeMap();
5151
codeMap.addLibrary(0x1500, newCodeEntry(0x3000, 'lib1'));
5252
codeMap.addLibrary(0x15500, newCodeEntry(0x5000, 'lib2'));
5353
codeMap.addLibrary(0x155500, newCodeEntry(0x10000, 'lib3'));
@@ -97,7 +97,7 @@ function assertNoEntry(codeMap, addr) {
9797

9898

9999
(function testDynamicCode() {
100-
var codeMap = new devtools.profiler.CodeMap();
100+
var codeMap = new CodeMap();
101101
codeMap.addCode(0x1500, newCodeEntry(0x200, 'code1'));
102102
codeMap.addCode(0x1700, newCodeEntry(0x100, 'code2'));
103103
codeMap.addCode(0x1900, newCodeEntry(0x50, 'code3'));
@@ -123,7 +123,7 @@ function assertNoEntry(codeMap, addr) {
123123

124124

125125
(function testCodeMovesAndDeletions() {
126-
var codeMap = new devtools.profiler.CodeMap();
126+
var codeMap = new CodeMap();
127127
codeMap.addCode(0x1500, newCodeEntry(0x200, 'code1'));
128128
codeMap.addCode(0x1700, newCodeEntry(0x100, 'code2'));
129129
assertEntry(codeMap, 'code1', 0x1500);
@@ -139,7 +139,7 @@ function assertNoEntry(codeMap, addr) {
139139

140140

141141
(function testDynamicNamesDuplicates() {
142-
var codeMap = new devtools.profiler.CodeMap();
142+
var codeMap = new CodeMap();
143143
// Code entries with same names but different addresses.
144144
codeMap.addCode(0x1500, newCodeEntry(0x200, 'code'));
145145
codeMap.addCode(0x1700, newCodeEntry(0x100, 'code'));
@@ -152,7 +152,7 @@ function assertNoEntry(codeMap, addr) {
152152

153153

154154
(function testStaticEntriesExport() {
155-
var codeMap = new devtools.profiler.CodeMap();
155+
var codeMap = new CodeMap();
156156
codeMap.addStaticCode(0x1500, newCodeEntry(0x3000, 'lib1'));
157157
codeMap.addStaticCode(0x15500, newCodeEntry(0x5000, 'lib2'));
158158
codeMap.addStaticCode(0x155500, newCodeEntry(0x10000, 'lib3'));
@@ -163,7 +163,7 @@ function assertNoEntry(codeMap, addr) {
163163

164164

165165
(function testDynamicEntriesExport() {
166-
var codeMap = new devtools.profiler.CodeMap();
166+
var codeMap = new CodeMap();
167167
codeMap.addCode(0x1500, newCodeEntry(0x200, 'code1'));
168168
codeMap.addCode(0x1700, newCodeEntry(0x100, 'code2'));
169169
codeMap.addCode(0x1900, newCodeEntry(0x50, 'code3'));

test/mjsunit/tools/csvparser.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
// Load CSV parser implementation from <project root>/tools.
2929
// Files: tools/csvparser.js
3030

31-
var parser = new devtools.profiler.CsvParser();
31+
var parser = new CsvParser();
3232

3333
assertEquals(
3434
[],

test/mjsunit/tools/profile.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ function countNodes(profile, traverseFunc) {
5858

5959

6060
function ProfileTestDriver() {
61-
this.profile = new devtools.profiler.Profile();
61+
this.profile = new Profile();
6262
this.stack_ = [];
6363
this.addFunctions_();
6464
};

test/mjsunit/tools/profile_view.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131

3232
function createNode(name, time, opt_parent) {
33-
var node = new devtools.profiler.ProfileView.Node(name, time, time, null);
33+
var node = new ProfileView.Node(name, time, time, null);
3434
if (opt_parent) {
3535
opt_parent.addChild(node);
3636
}
@@ -61,7 +61,7 @@ function createNode(name, time, opt_parent) {
6161
createNode('d', 4, b3);
6262
createNode('d', 2, b3);
6363

64-
var view = new devtools.profiler.ProfileView(root);
64+
var view = new ProfileView(root);
6565
var flatTree = [];
6666

6767
function fillFlatTree(node) {

test/mjsunit/tools/splaytree.js

+9-9
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,15 @@
3030

3131

3232
(function testIsEmpty() {
33-
var tree = new goog.structs.SplayTree();
33+
var tree = new SplayTree();
3434
assertTrue(tree.isEmpty());
3535
tree.insert(0, 'value');
3636
assertFalse(tree.isEmpty());
3737
})();
3838

3939

4040
(function testExportValues() {
41-
var tree = new goog.structs.SplayTree();
41+
var tree = new SplayTree();
4242
assertArrayEquals([], tree.exportValues());
4343
tree.insert(0, 'value');
4444
assertArrayEquals(['value'], tree.exportValues());
@@ -79,7 +79,7 @@ function createSampleTree() {
7979

8080

8181
(function testSplay() {
82-
var tree = new goog.structs.SplayTree();
82+
var tree = new SplayTree();
8383
tree.root_ = createSampleTree();
8484
assertArrayEquals(['50', '30', '60', '10', '40', '90', '20', '70', '100', '15', '80'],
8585
tree.exportValues());
@@ -93,7 +93,7 @@ function createSampleTree() {
9393

9494

9595
(function testInsert() {
96-
var tree = new goog.structs.SplayTree();
96+
var tree = new SplayTree();
9797
tree.insert(5, 'root');
9898
tree.insert(3, 'left');
9999
assertArrayEquals(['left', 'root'], tree.exportValues());
@@ -103,7 +103,7 @@ function createSampleTree() {
103103

104104

105105
(function testFind() {
106-
var tree = new goog.structs.SplayTree();
106+
var tree = new SplayTree();
107107
tree.insert(5, 'root');
108108
tree.insert(3, 'left');
109109
tree.insert(7, 'right');
@@ -117,7 +117,7 @@ function createSampleTree() {
117117

118118

119119
(function testFindMin() {
120-
var tree = new goog.structs.SplayTree();
120+
var tree = new SplayTree();
121121
assertEquals(null, tree.findMin());
122122
tree.insert(5, 'root');
123123
tree.insert(3, 'left');
@@ -127,7 +127,7 @@ function createSampleTree() {
127127

128128

129129
(function testFindMax() {
130-
var tree = new goog.structs.SplayTree();
130+
var tree = new SplayTree();
131131
assertEquals(null, tree.findMax());
132132
tree.insert(5, 'root');
133133
tree.insert(3, 'left');
@@ -137,7 +137,7 @@ function createSampleTree() {
137137

138138

139139
(function testFindGreatestLessThan() {
140-
var tree = new goog.structs.SplayTree();
140+
var tree = new SplayTree();
141141
assertEquals(null, tree.findGreatestLessThan(10));
142142
tree.insert(5, 'root');
143143
tree.insert(3, 'left');
@@ -151,7 +151,7 @@ function createSampleTree() {
151151

152152

153153
(function testRemove() {
154-
var tree = new goog.structs.SplayTree();
154+
var tree = new SplayTree();
155155
assertThrows('tree.remove(5)');
156156
tree.insert(5, 'root');
157157
tree.insert(3, 'left');

0 commit comments

Comments
 (0)