Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decimation API changed #90

Closed
jo-mueller opened this issue Apr 8, 2024 · 4 comments · May be fixed by #91
Closed

Decimation API changed #90

jo-mueller opened this issue Apr 8, 2024 · 4 comments · May be fixed by #91
Labels
bug Something isn't working

Comments

@jo-mueller
Copy link
Collaborator

Hi @haesleinhuepf ,

some of the more recent versions of vedo introduced some more API changes. In particular, the method keyword of the decimate function doesn't exist anymore - there are now separate functions decimate, decimate_pro and decimate_binned. Will send a PR to fix this and pinpoint vedo to a newer version.

Sidenote: This will probably make issue #87 more pressing. There are likely more problems with newer APIs (see also PR #88)
@jo-mueller jo-mueller added the bug Something isn't working label Apr 8, 2024
@haesleinhuepf
Copy link
Owner

Hi @jo-mueller ,

how about pinning the vedo version? They are breaking the API all the time causing efforts on our side.

Or are there any new features in vedo, that we need here?

Thanks!

Best,
Robert

@jo-mueller
Copy link
Collaborator Author

Hi @haesleinhuepf ,

how about pinning the vedo version?

This would probably work. I would have to go through the past few version though to see which change was introduced when. Would you be ok in fixing the last two changes (this issue and #87 ) and then pinning it? I am now a vedo maintainer so I can hopefully avert these kinds of breaking changes in the future :)

@haesleinhuepf
Copy link
Owner

Would you be ok in fixing the last two changes (this issue and #87 ) and then pinning it? I am now a vedo maintainer so I can hopefully avert these kinds of breaking changes in the future :)

Awesome! Do you want to take over this repository too? It would be your decision then.

@jo-mueller
Copy link
Collaborator Author

jo-mueller commented Apr 18, 2024 •
edited
Loading

I wouldn't mind :) Would you then leave it here or would you prefer moving the repository elsewhere?

Edit: tag :) @haesleinhuepf

@jo-mueller jo-mueller mentioned this issue May 13, 2024
Open
2 tasks
@jo-mueller jo-mueller mentioned this issue Jun 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update decimation api jo-mueller/napari-process-points-and-surfaces
2 participants
@haesleinhuepf @jo-mueller