-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests to PyPi package #17
Comments
Hey, By "adding the test to the Pypi package" what do you mean exactly (i'm not a "pro" packager by any means). Could you send me some example or reference to clarify what you meant? Also, thanks for using |
Well this git repository includes a folder called "tests". With this I can run As for my use-case, I'm not personally using this but it's a dependency of https://github.com/HelloChatterbox/text2speech, which in turn is a dependency of a project (HiveMind) building on top of MyCroft. |
Alright,good call, i'll try and fix that for you. I'll be putting my updates in a |
Well if you don't publish that branch to PyPi, there isn't much I can test 😉 May I ask why you don't tag release with git? That would for one fix my issue (as I don't need tests in PyPi persé, but mainly want a versioned source that includes the tests), but it would also allow you to go back to a previous version easily when for example bisecting or figuring out where bugs might have been introduced etc. |
Well, since tagging looked like the easier way, I tagged. Tell me if everything is fine on your side.
I don't know... I never felt like it was of any use since this is kind of a micropackage, and I thought I barely was the only one using it. Good to know that i was wrong! |
Closing since the solution as mentioned (tagged a Git release) works for me, thanks! 👍 |
@hadware seems 0.3.7 is out but there isn't a Git tag for it. Could you please start getting used to proper Git workflows and start tagging your releases? |
Re-opening as there isn't a Git tag for 0.3.7 and the tests are not included in the PyPi package yet. |
Please add the tests to the PyPi package. I'm packaging this for Alpine Linux and use the tagged release from PyPi, but those don't include the tests so we can't verify if the functionality of this package works at build time.
The text was updated successfully, but these errors were encountered: