Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Going between dev and prod signs you out #56

Open
toBeOfUse opened this issue Apr 29, 2024 · 1 comment
Open

Going between dev and prod signs you out #56

toBeOfUse opened this issue Apr 29, 2024 · 1 comment

Comments

@toBeOfUse
Copy link
Contributor

toBeOfUse commented Apr 29, 2024

We want cookies to be shared between the normal domain for the site and the staff subdomain for the site. Unfortunately, this also results in the browser trying to share cookies between khe.io, dev.khe.io, and localhost.khe.io. When you log into one version of the site, you overwrite the cookies that were created by any other version, logging you out of it. This is more of an annoyance for devs than a real problem; I'm not sure it's fixable.

@toBeOfUse
Copy link
Contributor Author

cookie: {
maxAge: 7 * 24 * 60 * 60 * 1000, // 7 days in ms
domain: ".khe.io", // assuming this site will be served under this domain!
},

^ Possibly narrowing down the domain used here based on the current site (perhaps using the publicSite/staffSite properties from the yaml configuration) would help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant