Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchors not changing current URL when document viewed as a folder item #546

Closed
KrzysztofMadejski opened this issue Sep 12, 2017 · 7 comments

Comments

@KrzysztofMadejski
Copy link

I've landed on Civic Tech Fest unconference notes on http://beta.hackfoldr.org/civictechfest/https%253A%252F%252Fhackmd.io%252FKwUwhgZgzAbAxsAtAIwBwAYKICxmAdhQEYQQd1URsYRUAmEATiiA and clicking links on documents section doesn't update URL.

I have to copy it manually from the TableOfContents list or from the section headers. Then it works. I see that the links have different format: https://hackmd.io/KwUwhgZgzAbAxsAtAIwBwAYKICxmAdhQEYQQd1URsYRUAmEATiiA#findings-of-the-taiwan-open-government-report-po-yu-tseng-and-mg-lee-open-culture-foundation-taiwan

Maybe the first link should redirect to the second?

@SISheogorath
Copy link
Contributor

I think this error is based on the fact, that http://beta.hackfoldr.org/civictechfest/https%253A%252F%252Fhackmd.io%252FKwUwhgZgzAbAxsAtAIwBwAYKICxmAdhQEYQQd1URsYRUAmEATiiA is only a wrapper that provides an iframe for https://hackmd.io/KwUwhgZgzAbAxsAtAIwBwAYKICxmAdhQEYQQd1URsYRUAmEATiiA#findings-of-the-taiwan-open-government-report-po-yu-tseng-and-mg-lee-open-culture-foundation-taiwan

Since iframes don't have access to the URL of the side they are embed on, there is no way for HackMD to update it.

But maybe I got your problem wrong and you mean something different

@KrzysztofMadejski
Copy link
Author

Yes, I believe you got it right. So anchors are not working when viewing the document in the catalogue view.

It really impacts sharing.

@KrzysztofMadejski KrzysztofMadejski changed the title Anchors not changing current URL sometimes [redirect problem] Anchors not changing current URL when document viewed as a folder item Sep 12, 2017
@SISheogorath
Copy link
Contributor

SISheogorath commented Sep 12, 2017

To me it looks less like a HackMD problem than more like a hackfolder problem in this case. Not sure how that can be handles by them, but since it's an iframe, we can't do anything outside.

My advice would be to visit hackmd.io directly.

@KrzysztofMadejski
Copy link
Author

KrzysztofMadejski commented Sep 12, 2017

That seems to be HackMD repo so I guess its problems belong here?

Could you tag/ping someone that have authority to resolve it? I don't know hackmd/hackfolder relations..

@KrzysztofMadejski
Copy link
Author

If I got the repo wrong I'd be grateful for a hint where should I post this issue.

@SISheogorath
Copy link
Contributor

It looks like @poga is one of the Hackfoldr people. Maybe he can clear the situation up.

@KrzysztofMadejski
Copy link
Author

I shouldn't report issues at 3pm. I've read it again and it's totally a hackfolder problem. Closing and reposting there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants