Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer? #53

Open
haacked opened this issue May 22, 2013 · 7 comments
Open

Installer? #53

haacked opened this issue May 22, 2013 · 7 comments

Comments

@haacked
Copy link
Owner

haacked commented May 22, 2013

Should we create an installer?

@Therzok
Copy link
Collaborator

Therzok commented May 23, 2013

I say we do and publish it on seegit.github.io :D

@marisks
Copy link
Contributor

marisks commented Sep 19, 2013

SeeGit also could be installed through chocolatey.org

@haacked
Copy link
Owner Author

haacked commented Sep 19, 2013

@marisks YES! Let's do that. :) Want to help?

@marisks
Copy link
Contributor

marisks commented Sep 20, 2013

I would like to help with creating Chocolatey package.

I think that at first only portable version should be created. For that only ZIP archive with executables will be needed. Could you upload such archive for Release 1.0?

@marisks
Copy link
Contributor

marisks commented Oct 17, 2013

I have created Chocolatey package, but there is an issue with running SeeGit from command line.
SeeGit can be run only from directory it resides. The issue is with configuration reading - it tries to read config from current directory, but not the application directory.
In Settings.cs ConfigurationManager.OpenMappedExeConfiguration is used to read configuration:

    public Settings()
    {
        var fileMap = new ExeConfigurationFileMap();
        fileMap.ExeConfigFilename = @"SeeGit.exe.config";
        _config = ConfigurationManager.OpenMappedExeConfiguration(fileMap, ConfigurationUserLevel.None);

        if (!_config.HasFile)
            throw new ConfigurationErrorsException("Config file not found.");
    }

But ConfigurationManager.OpenMappedExeConfiguration reads configuration from current directory and not from application directory.
Is there any reason to use OpenMappedExeConfiguration instead of OpenExeConfiguration? OpenExeConfiguration reads application config from application directory. The only difference is that you can't provide different file name.

@haacked
Copy link
Owner Author

haacked commented Oct 17, 2013

Is there any reason to use OpenMappedExeConfiguration instead of OpenExeConfiguration?

Umm, I have no idea honestly. 😛

I'm fine with changing it to OpenExeConfiguration if it makes it work with Chocolatey.

@haacked
Copy link
Owner Author

haacked commented Oct 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants