-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement AgentRelationship & AgentRelationshipRole classes: zomes + resolvers + tests #321
Comments
hi @pospi and @fosterlynn I have defined a scope of work for AgentRelationship and AgentRelationshipRole here. It looked pretty clear, but I have one question: how does this |
I think it's just meant to list all the roles that have been assigned as relationships to that agent. But it might not be that necessary for an MVP, I struggle to think of cases where this is useful whilst querying the relationships of an Agent is obviously an important thing. |
Yeah, can't even remember why that might be particularly useful. I would take it out of MMR or maybe out of hREA. |
I guess it may be useful to know "in what types of roles does this entity participate"? |
We can wait to find out if anyone needs it, there are lots of unimplemented and probably-never-to-be-implemented queries. Just imo. |
I want to describe what RoleBehavior is for, so you can decide if you want to leave it out or add it back in. Since the AgentRelationshipRoles are totally user defined, it is helpful for UI apps to have an understanding of what roles go where in an app. Like these roles are all members, or these are suppliers, or these are parts of the organization. Of course, these apps can also check the roles explicitly, but then it works only for that network or organization. If you decide to use RoleBehavior, we'll need to make a more complete and better thought through list and update the VF vocab. |
I'm mostly avoiding it and leaving it out, since it is such an unstable part of the spec. I would rather domain-specific app logic is dealing with conditions based on |
All of this should simply be added to the
agent
Dnahttps://lab.allmende.io/valueflows/vf-schemas/vf-graphql/-/blob/sprout/lib/schemas/agent.gql#L104-125
modules/vf-graphql-holochain
that is outlined belowtest/agent
Don't do:
AgentRelationship.inScopeOf
that can be done in #297Graphql
queries
mutations
edge resolvers
AgentRelationship.subject
AgentRelationship.object
AgentRelationship.relationship
Agent.relationships
(union ofAgentRelationship.subject
andAgentRelationship.object
)Agent.relationshipsAsSubject
(inverse ofAgentRelationship.subject
)Agent.relationshipsAsObject
(inverse ofAgentRelationship.object
)AgentRelationshipRole.agentRelationships
(inverse ofAgentRelationship.relationship
)The text was updated successfully, but these errors were encountered: