Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The demo.html file refers to files under the local javascript/ folder, but this is not on the repository #1

Open
juanmirocks opened this issue Jun 28, 2013 · 3 comments

Comments

@juanmirocks
Copy link
Collaborator

Should we commit the js files under javascript/ ?

@gyachdav
Copy link
Owner

gyachdav commented Jul 2, 2013

Not sure which folder you're referring to. just put it under /view and make the file name conform to the schema we discussed.

@juanmirocks
Copy link
Collaborator Author

For example in demo.html:

<script language="JavaScript" type="text/javascript" src="javascript/jquery/jquery.min.js"></script>
<script language="JavaScript" type="text/javascript" src="javascript/underscore/underscore-min.js"></script>

The folder javascript, however, does not exist in the repository. I wanted to test first using the demo.html, completely locally, that is, on my local machine. Not on any rostlab test or dev server.

@gyachdav
Copy link
Owner

gyachdav commented Jul 3, 2013

on pp-dev (and our other web servers) the javascript folder is shared system wide through the /javascript alias. That folder hosts 3rd party libraries such as query and underscore. Nothing of what we develop should go there. It is best if you just stick to the current application structure as we discussed.

On Jul 3, 2013, at 3:42 AM, Juan Miguel Cejuela wrote:

For example in demo.html:

<script language="JavaScript" type="text/javascript" src="javascript/jquery/jquery.min.js"></script> <script language="JavaScript" type="text/javascript" src="javascript/underscore/underscore-min.js"></script>

The folder javascript, however, does not exist in the repository. I wanted to test first using the demo.html, completely locally, that is, on my local machine. Not on any rostlab test or dev server.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants