Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GWT's polyfill for Map #10062

Closed
niloc132 opened this issue Dec 15, 2024 · 0 comments · Fixed by #10063
Closed

Remove GWT's polyfill for Map #10062

niloc132 opened this issue Dec 15, 2024 · 0 comments · Fixed by #10063

Comments

@niloc132
Copy link
Member

GWT contains a polyfill for Map, used to implement java.util.Map where the key was a string (and avoid hashing the string in JS).

The polyfill contains implementation details for sufficiently old browsers that

  • did not support Map at all
  • threw an exception instead of using the iterator protocol (ff 24-25 apparently)

Additionally the polyfill itself has special handling for browsers that didn't correctly support Object.create(null).

The jsinterop mapping supports old browsers that couldn't use delete as a method name, which is no longer needed.
niloc132 added a commit to niloc132/gwt that referenced this issue Dec 15, 2024
@niloc132
Remove GWT's Map polyfill
3ffae87 
Fixes gwtproject#10062
niloc132 added a commit to niloc132/gwt that referenced this issue Dec 16, 2024
@niloc132
Remove GWT's Map polyfill
313583c 
Fixes gwtproject#10062
niloc132 added a commit to niloc132/gwt that referenced this issue Dec 16, 2024
@niloc132
Remove GWT's Map polyfill
5b70637 
Fixes gwtproject#10062
@niloc132 niloc132 mentioned this issue Dec 16, 2024
Merged
niloc132 added a commit to niloc132/gwt that referenced this issue Jan 8, 2025
@niloc132
Remove GWT's Map polyfill
1da3002 
Fixes gwtproject#10062
vegegoku pushed a commit to vegegoku/gwt that referenced this issue Jan 9, 2025
@niloc132 @vegegoku
Remove GWT's Map polyfill (gwtproject#10063)
c08f7a1 
All currently supported browsers have a working Map implementation, so
we don't need to include this in every compiled GWT application.

Fixes gwtproject#10062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove GWT's Map polyfill niloc132/gwt
1 participant
@niloc132