Skip to content
This repository has been archived by the owner on Aug 5, 2019. It is now read-only.

DateBox.setFormat buggy #460

Open
reinert opened this issue Nov 27, 2013 · 2 comments
Open

DateBox.setFormat buggy #460

reinert opened this issue Nov 27, 2013 · 2 comments
Assignees
Labels

Comments

@reinert
Copy link
Contributor

reinert commented Nov 27, 2013

There's a bug in the setFormat method of DateBox at L119.

Some unexpected replaceAll is being performed, altering default behavior of any format using "MM" segment.

I'll fix it soon.

[WARNING] If anyone is using setFormat with "mm" segment it will be broken after the patch

@ghost ghost assigned reinert Nov 27, 2013
@reinert
Copy link
Contributor Author

reinert commented Jan 17, 2014

This bug, actually is pretty well intended.

DateTimeBoxBase has a processing changing formats.
https://github.com/gwtbootstrap/gwt-bootstrap/blob/master/src/main/java/com/github/gwtbootstrap/datetimepicker/client/ui/base/DateTimeBoxBase.java#L686

I wonder why these processing were implemented???

Why not rely on default and expected formats??

I'm afraid of removing these processing and break existing projects.

I do need opinion form others.

@caarlos0
Copy link
Contributor

seems like these changes were made by @rexorient... maybe he can say something about that..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants