Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling skygrids at the workflow level #4963

Open
sebastiangomezlopez opened this issue Dec 2, 2024 · 4 comments
Open

Enabling skygrids at the workflow level #4963

sebastiangomezlopez opened this issue Dec 2, 2024 · 4 comments
Assignees
Labels
PyGRB PyGRB development

Comments

@sebastiangomezlopez
Copy link
Contributor

Even though the skygrid functionalities have been implemented inside pycbc_multi_inspiral, at the moment we can not pass skygrids as input when generating PyGRB workflows.

Unlike our initial tests on GRB170817A, where a single point in the grid is enough. We need this implementation for GRBs that are poorly resolved in the sky.

@pannarale
Copy link
Contributor

I started looking at where to change the code and I realised that even generating injections will have to take into account the sky uncertainty. @sebastiangomezlopez told me that @MarcoCusinato and @Thomas-JACQUOT both brought this up on a call.

@titodalcanton
Copy link
Contributor

@pannarale in my view, the sky location of injections would be handled directly by drawing the distribution for ra and dec from either fisher_sky or healpix_sky (once #4848 is merged).

@MarcoCusinato
Copy link
Contributor

@pannarale, @titodalcanton brought up the idea of appending the sky type and ra and dec from the workflow to the injections. I think that probably one of the easiest ways would be to create the files needed to do the injections at a workflow levels like in here. Then use them to run the injection workflow.

@pannarale
Copy link
Contributor

Note to self: we can remove ipn_file, ipn_sky_points and other related things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyGRB PyGRB development
Projects
Status: In Progress
Development

No branches or pull requests

4 participants