Skip to content

Update PyGRB Workflow Generation #4045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakeb245 opened this issue Jun 1, 2022 · 2 comments
Closed

Update PyGRB Workflow Generation #4045

jakeb245 opened this issue Jun 1, 2022 · 2 comments
Assignees
Labels
PyGRB PyGRB development

Comments

@jakeb245
Copy link
Contributor

jakeb245 commented Jun 1, 2022

Lots of work has been done on the PyGRB pipeline, but the workflow generation script hasn't been updated in 3 years! It is quite out of date with rest of the pipeline and PyCBC as a whole. Work is being done to bring the workflow generation up to date in this branch. Any discussion, advice, etc. is welcome!

Things done so far:

  • Updated segment generation to work with current PyCBC modules
  • Updated workflow to successfully run pycbc_multi_inspiral (that is: a run with pycbc_hdf5_splitbank and pycbc_multi_inspiral as executables)
  • Various fixes along the way to make the above things work

Things to do:

  • Reimplement injections, time slides, and post-processing with updated code
  • Either reimplement gating in workflow generation or move gating into workflow
  • Keep workflow up to date with current development
  • Move some LAL dependent files around in the GRB utilities code
  • Fix bugs!
@jakeb245 jakeb245 added the PyGRB PyGRB development label Jun 1, 2022
@jakeb245 jakeb245 self-assigned this Jun 1, 2022
@ahnitz
Copy link
Member

ahnitz commented Jun 1, 2022

@jakeb245 Once this is complete, I might suggest adding a unittest similar to what we have for the coincident search workflow (i.e. a full run of some analysis but with settings to bring the runtime to ~ 30 minutes). That way we can prevent anyone breaking the pipeline and if changes are needed they have to be reflected there too.

@jakeb245 jakeb245 moved this to In Progress in PyGRB Development Jun 1, 2022
@pannarale
Copy link
Contributor

I'm closing this issue as it is superseded by #4288 (and future PRs that will follow it).

@github-project-automation github-project-automation bot moved this from In Progress to Done in PyGRB Development Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyGRB PyGRB development
Projects
Status: Done
Development

No branches or pull requests

3 participants