Add Node 8 and Node 9 to continuous integration testing#494
Merged
guyonroche merged 3 commits intoexceljs:masterfrom Mar 6, 2018
Merged
Add Node 8 and Node 9 to continuous integration testing#494guyonroche merged 3 commits intoexceljs:masterfrom
guyonroche merged 3 commits intoexceljs:masterfrom
Conversation
Contributor
Author
|
Hi @guyonroche Is there an issue with this PR? I see you've been merging PR's recently and just wanted to check in |
Collaborator
|
Hi @cooltoast - I'm reviewing this PR right now - as mentioned, I am currently overworked with very little time to spare. I'm trying to set aside a little time each day to catch up with all the PRs... they kinda sneaked up on me! |
Contributor
Author
|
Hey @guyonroche thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @guyonroche,
I appreciate your work on this package! I use it regularly in different node environments, and I think using simple continuous integration would be very helpful for me (and possibly others) to understand this package's node compatibility, and for ensuring tests pass for pull requests and new features.
In a previous PR I've added a
.travis.ymlfile that TravisCI can use. It's free of charge, and the good news is that the tests pass in Node versions 6-9!Please consider activating this repo in TravisCI: https://docs.travis-ci.com/user/getting-started/
Upon the next pushed commit, it'll immediately build and run the tests you've written.
Thanks!