Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the color of the cropping border line #401

Closed
ByLiangCheng opened this issue Jul 15, 2024 · 9 comments · Fixed by #403
Closed

About the color of the cropping border line #401

ByLiangCheng opened this issue Jul 15, 2024 · 9 comments · Fixed by #403

Comments

@ByLiangCheng
Copy link

I configured the color in config.cropViewConfig.cropBorderColor, but it seems to have no effect after setting it. I wonder if it is supported?

Because my config.cropViewConfig.backgroundColor is set to white, in this case, the crop line and the background color will be the same, making it impossible to see whether it exists, but in fact I need it to be displayed prominently.

I would appreciate any help in resolving this issue.

@ByLiangCheng
Copy link
Author

Sample video :

Jietu20240716-030536-HD.mp4

@guoyingtao
Copy link
Owner

guoyingtao commented Jul 18, 2024

@ByLiangCheng
config.cropViewConfig.cropBorderColor is for the border of the cropped image like below, it is not for the cropping box whose border is always white currently.

image

@ByLiangCheng
Copy link
Author

Will you consider supporting the configuration of a cropping frame that is always white in the future? Because when my background is white, the cropping frame is always white, which makes it invisible.

@guoyingtao
Copy link
Owner

@ByLiangCheng
Yes, I will consider supporting this configuration in the next release.

@ByLiangCheng
Copy link
Author

Thanks, looking forward to the update

@mihapp
Copy link

mihapp commented Jul 19, 2024

I'm also looking forward for this update, I have similar issue with white background...

@guoyingtao
Copy link
Owner

@ByLiangCheng @mihapp
Can you try PR #403 to see if it meets your requirement?

You may need to modify color properties of CropViewConfig.cropAuxiliaryIndicatorConfig

@ByLiangCheng
Copy link
Author

@ByLiangCheng @mihapp Can you try PR #403 to see if it meets your requirement?

You may need to modify color properties of CropViewConfig.cropAuxiliaryIndicatorConfig

Thank you for your support, I successfully solved it with this configuration

@guoyingtao
Copy link
Owner

@ByLiangCheng
I released Mantis 2.22.0 which includes PR #403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants