diff --git a/dag/extdeps/systems/nvidia.dag b/dag/extdeps/systems/nvidia.dag index fc61f41eebd..2c0c799fb9e 100644 --- a/dag/extdeps/systems/nvidia.dag +++ b/dag/extdeps/systems/nvidia.dag @@ -88,6 +88,10 @@ data dgx_spark_network_ports: List = [ SystemNetworkPort { medium: ShortRangeWireless, product_name: "Bluetooth 5.4", bandwidth: none }, ] +// dgx_spark_catalog_row's memory field: on a UnifiedShared SoC the GPU-facing and +// system-facing memory are one physical fact, not two independent ones, so it derives +// from the already-cited nvidia_gb10_gpu_catalog row instead of re-asserting the same +// 128 GiB / 273 GB/s literals a second time (review 49122; DESIGN §3 parallel-representation). fn dgx_spark_catalog_row(storage_capacity: ByteSize) -> IntegratedComputeSystemCatalogRow { IntegratedComputeSystemCatalogRow { vendor: nvidia, @@ -96,10 +100,6 @@ fn dgx_spark_catalog_row(storage_capacity: ByteSize) -> IntegratedComputeSystemC cpu_architecture: Aarch64, cpu_core_clusters: dgx_spark_cpu_core_clusters, gpu: nvidia_gb10_gpu_catalog, - // On a UnifiedShared SoC the GPU-facing and system-facing memory are one physical - // fact, not two independent ones: derive both fields from the already-cited - // nvidia_gb10_gpu_catalog row instead of re-asserting the same 128 GiB / 273 GB/s - // literals a second time (review 49122; DESIGN §3 parallel-representation). memory: nvidia_gb10_gpu_catalog.memory, memory_bus_width: bit_width(count: 256), memory_data_rate: hertz(count: 4266000000), diff --git a/dag/test/claim/generated_artifact_drift_test.dag b/dag/test/claim/generated_artifact_drift_test.dag index 94ebf36d18d..88073b5b987 100644 --- a/dag/test/claim/generated_artifact_drift_test.dag +++ b/dag/test/claim/generated_artifact_drift_test.dag @@ -358,6 +358,11 @@ test fn witness_binding_refusal_retains_its_locator() -> Bool { } } +// The third clause of witness_refusal_cause_tokens_are_pairwise_distinct pins what +// refusal_causes_token's fold relies on: it reuses the empty-population marker as its +// own "nothing accumulated yet" state, so a cause token colliding with that marker +// would make the first joined cause silently replace the marker instead of appending. +// Safe today by coincidence; this makes it safe by execution (review 49204). test fn witness_refusal_cause_tokens_are_pairwise_distinct() -> Bool { let causes = [ ActionsJobCredentialScopeUnavailable, ActionsJobCredentialScopeNotGranted, @@ -373,11 +378,6 @@ test fn witness_refusal_cause_tokens_are_pairwise_distinct() -> Bool { xs: tokens, empty: true, cons: fn(ok, t) { - // The third clause pins what refusal_causes_token's fold relies on: - // it reuses the empty-population marker as its own "nothing accumulated - // yet" state, so a cause token colliding with that marker would make the - // first joined cause silently replace the marker instead of appending. - // Safe today by coincidence; this makes it safe by execution (review 49204). ok && (count(filter(tokens, u => u == t)) == 1) && (t != "") && (t != "HealPushRefusalPopulationEmpty") }