From 9bf543b8b8385950dc0874232210b377371a7dcf Mon Sep 17 00:00:00 2001
From: Brian Searls <briansearls1@gmail.com>
Date: Sun, 4 Oct 2026 13:22:50 +0000
Subject: [PATCH] Declare <T> on the 6 generic fns that used an undeclared type
 parameter

json.parse json_field_value/json_field_cause, docker container_inspect
nested_value/nested_causes, mtjade1_access_observation read_cause,
mtcollins1_boot_diagnostic_bundle members_channel each used T without a <T>,
resolving only through the module-scope leak of a generic type's parameters.
The Rust emitter renders only declared parameters, so each emitted as a
generic fn without its type parameter (E0425 'cannot find type T'). Each T is
the fresh parameter of the reading type it consumes.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
---
 dag/extdeps/docker/container_inspect.dag                      | 4 ++--
 dag/extdeps/languages/json/parse.dag                          | 4 ++--
 .../machine_intake/mtcollins1_boot_diagnostic_bundle.dag      | 2 +-
 dag/gunbc/machine_intake/mtjade1_access_observation.dag       | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/dag/extdeps/docker/container_inspect.dag b/dag/extdeps/docker/container_inspect.dag
index 325fa5b143f..deeaebae26b 100644
--- a/dag/extdeps/docker/container_inspect.dag
+++ b/dag/extdeps/docker/container_inspect.dag
@@ -953,7 +953,7 @@ fn docker_inspect_nested_network_settings(obj: JsonValue) -> NestedObjectRead<Ne
 // ONE FOLD, NOT THREE INSTANTIATIONS OF IT. A first cut carried a byte-identical copy per nested
 // type because the field access at ONE call site could not infer `T` -- and the answer to that is
 // to name the type at that site, not to mint three declarations of one concept in a shared decoder.
-fn nested_value(r: NestedObjectRead<T>) -> T? {
+fn nested_value<T>(r: NestedObjectRead<T>) -> T? {
   match r {
     NestedAbsent => none
     NestedMalformed { causes: _ } => none
@@ -961,7 +961,7 @@ fn nested_value(r: NestedObjectRead<T>) -> T? {
   }
 }
 
-fn nested_causes(r: NestedObjectRead<T>) -> List<String> {
+fn nested_causes<T>(r: NestedObjectRead<T>) -> List<String> {
   match r {
     NestedAbsent => []
     NestedMalformed { causes: cs } => cs
diff --git a/dag/extdeps/languages/json/parse.dag b/dag/extdeps/languages/json/parse.dag
index ec793f70d17..cab71e9a4d1 100644
--- a/dag/extdeps/languages/json/parse.dag
+++ b/dag/extdeps/languages/json/parse.dag
@@ -635,7 +635,7 @@ fn json_field_string_list(obj: JsonValue, key: String) -> JsonFieldRead<List<Str
 // matches would report the first and hide the rest, which turns one decode into four round trips
 // against a live daemon -- and against a CAPTURE, which cannot be re-run at all, it would hide
 // findings permanently.
-fn json_field_value(r: JsonFieldRead<T>) -> T? {
+fn json_field_value<T>(r: JsonFieldRead<T>) -> T? {
   match r {
     FieldAbsent => none
     FieldMalformed { cause: _ } => none
@@ -644,7 +644,7 @@ fn json_field_value(r: JsonFieldRead<T>) -> T? {
 }
 
 
-fn json_field_cause(r: JsonFieldRead<T>) -> String? {
+fn json_field_cause<T>(r: JsonFieldRead<T>) -> String? {
   match r {
     FieldAbsent => none
     FieldMalformed { cause: c } => Present { value: c }
diff --git a/dag/gunbc/machine_intake/mtcollins1_boot_diagnostic_bundle.dag b/dag/gunbc/machine_intake/mtcollins1_boot_diagnostic_bundle.dag
index 13ec0b54e56..2d3b146a245 100644
--- a/dag/gunbc/machine_intake/mtcollins1_boot_diagnostic_bundle.dag
+++ b/dag/gunbc/machine_intake/mtcollins1_boot_diagnostic_bundle.dag
@@ -1313,7 +1313,7 @@ fn sel_channel(channel: NonEmptyStr, s: SelSnapshotReading) -> BmcChannelRead {
   } }
 }
 
-fn members_channel(channel: NonEmptyStr, m: MembersReading<T>) -> BmcChannelRead {
+fn members_channel<T>(channel: NonEmptyStr, m: MembersReading<T>) -> BmcChannelRead {
   BmcChannelRead { channel: channel, standing: match m {
     MembersRead { members: _ } => BmcChannelAnswered
     MembersUnread { cause: c } => BmcChannelFailed { cause: c }
diff --git a/dag/gunbc/machine_intake/mtjade1_access_observation.dag b/dag/gunbc/machine_intake/mtjade1_access_observation.dag
index 9da029f5192..5105c9d1894 100644
--- a/dag/gunbc/machine_intake/mtjade1_access_observation.dag
+++ b/dag/gunbc/machine_intake/mtjade1_access_observation.dag
@@ -115,7 +115,7 @@ fn field_unread(field: NonEmptyStr, cause: String) -> RecordedManagerDecode {
   RecordedManagerRefused { gap: CaptureFieldUnread { field: field, cause: cause } }
 }
 
-fn read_cause(r: JsonFieldRead<T>) -> String {
+fn read_cause<T>(r: JsonFieldRead<T>) -> String {
   match r {
     FieldAbsent => "absent"
     FieldMalformed { cause: c } => c