From 72d0f5fe6fe0dfe4d416774da76adac79e5eb247 Mon Sep 17 00:00:00 2001 From: Guillermo Prandi Date: Sat, 9 Nov 2019 01:07:48 -0300 Subject: [PATCH] Simplify permission checks --- models/action.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/models/action.go b/models/action.go index 3518c0c01661..530f8e6963fb 100644 --- a/models/action.go +++ b/models/action.go @@ -490,8 +490,8 @@ func UpdateIssuesCommit(doer *User, repo *Repository, commits []*PushCommit, bra refMarked[key] = true // FIXME: this kind of condition is all over the code, it should be consolidated in a single place - canclose := perm.IsAdmin() || perm.IsOwner() || perm.CanWrite(UnitTypeIssues) || refIssue.PosterID == doer.ID - cancomment := canclose || perm.CanRead(UnitTypeIssues) + canclose := perm.CanWrite(UnitTypeIssues) || refIssue.PosterID == doer.ID + cancomment := perm.CanRead(UnitTypeIssues) // Don't proceed if the user can't comment if !cancomment {