Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2.13 support #116

Open
REASY opened this issue Jul 24, 2021 · 7 comments
Open

Scala 2.13 support #116

REASY opened this issue Jul 24, 2021 · 7 comments
Labels
invalid This doesn't seem right

Comments

@REASY
Copy link

REASY commented Jul 24, 2021

Quickly tried to just update the version to 2.13.6 and compile the project, it didn't work:
image

image
Error:

sbt-guardrail(master)> compile
[warn]
[warn]  Note: Unresolved dependencies path:
[error] stack trace is suppressed; run last core / update for the full output
[error] (core / update) sbt.librarymanagement.ResolveException: Error downloading org.scala-sbt:scripted-sbt_2.13:1.5.5
[error]   Not found
[error]   Not found
[error]   not found: https://repo1.maven.org/maven2/org/scala-sbt/scripted-sbt_2.13/1.5.5/scripted-sbt_2.13-1.5.5.pom
[error]   not found: C:\Users\User\.ivy2\localorg.scala-sbt\scripted-sbt_2.13\1.5.5\ivys\ivy.xml
[error]   not found: https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.scala-sbt/scripted-sbt_2.13/1.5.5/ivys/ivy.xml
[error]   not found: https://repo.typesafe.com/typesafe/ivy-releases/org.scala-sbt/scripted-sbt_2.13/1.5.5/ivys/ivy.xml
[error] Total time: 7 s, completed Jul 24, 2021 5:28:02 PM
@blast-hardcheese
Copy link
Member

Sorry for the delay in response! My GitHub Notifications got screwed up, I just re-watched all guardrail repositories a few weeks ago, but I didn't see your issue here.

sbt-guardrail is limited to 2.12 currently because sbt itself is limited to 2.12. guardrail will generate source code compatible with Scala 2.11, 2.12, and 2.13 (2.13 will also be usable from Scala 3 when using 2.13 source compatibility mode)

@blast-hardcheese blast-hardcheese added the invalid This doesn't seem right label Oct 20, 2021
@blast-hardcheese
Copy link
Member

Going to leave this open as some sort of documentation for those who run down the same thought experiment

@Veske
Copy link

Veske commented Nov 30, 2021

Should cross-builds work as well with the guardrail task ? I.e should + guardrail being run in a project produce generated clients and servers under both target/scala-2.13 and target/scala-2.12 in case these are the provided crossScalaVersions in the build.sbt ?

@blast-hardcheese
Copy link
Member

@Veske That is expected to work, yes. It looks like the sbt task caching is scoped to target/, not target/scala-* as I expected. PR incoming.

@blast-hardcheese
Copy link
Member

#149

@Veske
Copy link

Veske commented Nov 30, 2021

#149

Thank you for that ! I will try it out in the morning.

@blast-hardcheese
Copy link
Member

0.69.0.1 was released with that change, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants