Skip to content

Commit c80415a

Browse files
Clarifying that these are not actually conditional return values
1 parent b2a2841 commit c80415a

File tree

1 file changed

+5
-11
lines changed

1 file changed

+5
-11
lines changed

modules/scala-support/src/main/scala/dev/guardrail/generators/scala/circe/CirceProtocolGenerator.scala

+5-11
Original file line numberDiff line numberDiff line change
@@ -334,11 +334,9 @@ class CirceProtocolGenerator private (circeVersion: CirceModelGenerator, applyVa
334334
q"$acc ++ $field"
335335
}
336336

337-
Option(
338-
q"""
337+
q"""
339338
${circeVersion.encoderObjectCompanion}.instance[${Type.Name(clsName)}](a => _root_.io.circe.JsonObject.fromIterable($allFields))
340339
"""
341-
)
342340
}
343341
val (readOnlyDefn, readOnlyFilter) = NonEmptyList.fromList(readOnlyKeys).fold((List.empty[Stat], identity[Term] _)) { roKeys =>
344342
(
@@ -347,7 +345,7 @@ class CirceProtocolGenerator private (circeVersion: CirceModelGenerator, applyVa
347345
)
348346
}
349347

350-
Target.pure(encVal.map(encVal => q"""
348+
Target.pure(Option(q"""
351349
implicit val ${suffixClsName("encode", clsName)}: ${circeVersion.encoderObject}[${Type.Name(clsName)}] = {
352350
..${readOnlyDefn};
353351
${readOnlyFilter(encVal)}
@@ -373,14 +371,12 @@ class CirceProtocolGenerator private (circeVersion: CirceModelGenerator, applyVa
373371
decVal <-
374372
if (paramCount == 0) {
375373
Target.pure(
376-
Option[Term](
377-
q"""
374+
q"""
378375
new _root_.io.circe.Decoder[${Type.Name(clsName)}] {
379376
final def apply(c: _root_.io.circe.HCursor): _root_.io.circe.Decoder.Result[${Type.Name(clsName)}] =
380377
_root_.scala.Right(${Term.Name(clsName)}())
381378
}
382379
"""
383-
)
384380
)
385381
} else {
386382
params.zipWithIndex
@@ -452,19 +448,17 @@ class CirceProtocolGenerator private (circeVersion: CirceModelGenerator, applyVa
452448
}
453449
.map { pairs =>
454450
val (terms, enumerators) = pairs.unzip
455-
Option(
456-
q"""
451+
q"""
457452
new _root_.io.circe.Decoder[${Type.Name(clsName)}] {
458453
final def apply(c: _root_.io.circe.HCursor): _root_.io.circe.Decoder.Result[${Type.Name(clsName)}] =
459454
for {
460455
..${enumerators}
461456
} yield ${Term.Name(clsName)}(..${terms})
462457
}
463458
"""
464-
)
465459
}
466460
}
467-
} yield decVal.map(decVal => q"""
461+
} yield Option(q"""
468462
implicit val ${suffixClsName("decode", clsName)}: _root_.io.circe.Decoder[${Type.Name(clsName)}] = $decVal
469463
""")
470464
}

0 commit comments

Comments
 (0)