Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DCR assets loading with frontend dev #13052

Open
DanielCliftonGuardian opened this issue Dec 24, 2024 · 1 comment · May be fixed by #13047
Open

DCR assets loading with frontend dev #13052

DanielCliftonGuardian opened this issue Dec 24, 2024 · 1 comment · May be fixed by #13047
Assignees
@DanielCliftonGuardian
Milestone
Health

Comments

@DanielCliftonGuardian
Copy link
Contributor

Some assets not loading on dcr pages in frontend locally due to a relative path being used here

dotcom-rendering/dotcom-rendering/src/client/decidePublicPath.ts

Line 11 in 121ed9b

? '/assets/'
so assets are trying to load from port 9000 instead of 3030
@DanielCliftonGuardian DanielCliftonGuardian self-assigned this Dec 24, 2024
@github-project-automation github-project-automation bot moved this to Triage in WebX Team Dec 24, 2024
@DanielCliftonGuardian DanielCliftonGuardian moved this from Triage to In Progress in WebX Team Dec 24, 2024
@DanielCliftonGuardian DanielCliftonGuardian added this to the Health milestone Dec 24, 2024
@DanielCliftonGuardian DanielCliftonGuardian linked a pull request Dec 24, 2024 that will close this issue
Draft
@JamieB-gu JamieB-gu marked this as a duplicate of #10538 Jan 6, 2025
@SiAdcock
Copy link
Contributor

SiAdcock commented Jan 6, 2025

See also:

@SiAdcock SiAdcock removed their assignment Jan 6, 2025
@SiAdcock SiAdcock moved this from In Progress to This Sprint in WebX Team Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielCliftonGuardian DanielCliftonGuardian

Labels
None yet
Projects
WebX Team
Status: This Sprint
Milestone
Health
Development

Successfully merging a pull request may close this issue.

Use base url when on localhost for assets guardian/dotcom-rendering
2 participants
@SiAdcock @DanielCliftonGuardian