From fed2598a8643728dc208a3e65af7d49e9368347b Mon Sep 17 00:00:00 2001 From: akash1810 Date: Wed, 18 Sep 2024 18:25:52 +0100 Subject: [PATCH] chore: Add changeset --- .changeset/breezy-waves-develop.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 .changeset/breezy-waves-develop.md diff --git a/.changeset/breezy-waves-develop.md b/.changeset/breezy-waves-develop.md new file mode 100644 index 000000000..3a6a57684 --- /dev/null +++ b/.changeset/breezy-waves-develop.md @@ -0,0 +1,12 @@ +--- +"@guardian/cdk": patch +--- + +fix(experimental-ec2-pattern): Add buffer to rolling update timeout + +If we consider the health check grace period to be the time it takes the "normal" user data to run, +the rolling update should be configured to be a little longer to cover the additional time spent polling the target group. + +A buffer of 1 minute is somewhat arbitrarily chosen. +Too high a value, then we increase the time it takes to automatically rollback from a failing healthcheck. +Too low a value, then we risk flaky deploys.