From dcac71de63f7fbca1c97cb3d72ccca6f8f035cb7 Mon Sep 17 00:00:00 2001
From: Akash Askoolum <akash1810@gmail.com>
Date: Fri, 12 Feb 2021 16:47:31 +0000
Subject: [PATCH] remove explicit testing of GuStageParameter and
 GuStackParameter

A GuParameter now relies on a function from GuStack, as GuStageParameter and GuStackParameter are automatically added to a GuStack, we cannot explicitly test them now as its recursuve.

Remove them in favour of a slightly implicit test in stack.test.ts.
---
 src/constructs/core/parameters.test.ts | 38 --------------------------
 1 file changed, 38 deletions(-)

diff --git a/src/constructs/core/parameters.test.ts b/src/constructs/core/parameters.test.ts
index ff7c53b60b..55b0fa0d10 100644
--- a/src/constructs/core/parameters.test.ts
+++ b/src/constructs/core/parameters.test.ts
@@ -1,22 +1,17 @@
 import "@aws-cdk/assert/jest";
 import { SynthUtils } from "@aws-cdk/assert/lib/synth-utils";
-import { Stack } from "@aws-cdk/core";
 import { simpleGuStackForTesting } from "../../../test/utils";
 import type { SynthedStack } from "../../../test/utils";
-import { Stage, Stages } from "../../constants";
 import {
   GuAmiParameter,
   GuArnParameter,
   GuInstanceTypeParameter,
   GuParameter,
   GuS3ObjectArnParameter,
-  GuStackParameter,
-  GuStageParameter,
   GuStringParameter,
   GuSubnetListParameter,
   GuVpcParameter,
 } from "./parameters";
-import type { GuStack } from "./stack";
 
 describe("The GuParameter class", () => {
   it("sets the type as passed through by default", () => {
@@ -84,39 +79,6 @@ describe("The GuStringParameter class", () => {
   });
 });
 
-describe("The GuStageParameter class", () => {
-  it("should set the values as required", () => {
-    const stack = new Stack() as GuStack;
-
-    new GuStageParameter(stack);
-
-    const json = SynthUtils.toCloudFormation(stack) as SynthedStack;
-
-    expect(json.Parameters.Stage).toEqual({
-      Type: "String",
-      Description: "Stage name",
-      AllowedValues: Stages,
-      Default: Stage.CODE,
-    });
-  });
-});
-
-describe("The GuStackParameter class", () => {
-  it("should set the values as required", () => {
-    const stack = new Stack() as GuStack;
-
-    new GuStackParameter(stack);
-
-    const json = SynthUtils.toCloudFormation(stack) as SynthedStack;
-
-    expect(json.Parameters.Stack).toEqual({
-      Type: "String",
-      Description: "Name of this stack",
-      Default: "deploy",
-    });
-  });
-});
-
 describe("The GuInstanceTypeParameter class", () => {
   it("should combine default, override and prop values", () => {
     const stack = simpleGuStackForTesting();