Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Check markdown format" work flow does not properly fail #86

Open
rmetzman opened this issue Aug 11, 2023 · 0 comments
Open

The "Check markdown format" work flow does not properly fail #86

rmetzman opened this issue Aug 11, 2023 · 0 comments

Comments

@rmetzman
Copy link
Contributor

rmetzman commented Aug 11, 2023

The "Check markdown format" step in the github presubmits does not properly fail at that step if there is a diff in the expected format, it fails at the next step which is confusing to figure out what caused the problem.

Specifically this is the command in the ci.yaml file: "npx --yes prettier --write --prose-wrap always *.md"

If it needs to be run, it fails at the next step (Check that all markdown is up to date) which makes the error message ambiguous because it says "git status -s && test -z "$(git status -s)" instead of that the previous command needs to be run to fix the formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant