Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seal Ext / ImplExt traits #1093

Closed
bilelmoussaoui opened this issue May 4, 2023 · 7 comments
Closed

Seal Ext / ImplExt traits #1093

bilelmoussaoui opened this issue May 4, 2023 · 7 comments
Assignees
@bilelmoussaoui
Labels
enhancement New feature or request
Milestone
0.18.0

Comments

@bilelmoussaoui
Copy link
Member

We should look at which traits must be sealed other then the ones mentioned in the issue title.
@bilelmoussaoui bilelmoussaoui added the enhancement New feature or request label May 4, 2023
@bilelmoussaoui bilelmoussaoui added this to the 0.18.0 milestone May 4, 2023
@bilelmoussaoui bilelmoussaoui self-assigned this May 4, 2023
@bilelmoussaoui
Copy link
Member Author

cc @jf2048

@bilelmoussaoui bilelmoussaoui mentioned this issue May 4, 2023
Merged
@jf2048
Copy link
Member

jf2048 commented May 4, 2023 •
edited
Loading

Here is a list of glib traits that are not sealed and not implemented by any macro:

  • 🦭 Cast
  • 🦭 CastNone
  • ClassStruct
  • 🦭 FixedSizeVariantType
  • FromGlibContainer
  • FromGlibPtrContainer
  • InstanceStruct
  • 🦭 InterfaceList
  • 🦭 IntoClosureReturnValue
  • IntoGStr
  • IntoOptionalGStr
  • IntoPtrSlice
  • IntoStrV
  • IsImplementable
  • 🦭 IsSubclassable
  • 🦭 IsSubclassableDefault
  • 🦭 MayDowncastTo
  • OptionIntoGlib
  • 🦭 PrerequisiteList
  • Property
  • PropertyGet
  • PropertySet
  • PropertySetNested
  • 🦭 Ptr
  • RefCounted
  • 🦭 ToSendValue
  • 🦭 TryFromClosureReturnValue
  • ValueTypeChecker
  • 🦭 Watchable

I put 🦭 next to the ones I think should probably be sealed

@jf2048
Copy link
Member

jf2048 commented May 4, 2023

Seems simple enough for gtk3: gtk-rs/gtk3-rs#821

Now to add it to gir?

@jf2048 jf2048 mentioned this issue May 5, 2023
Merged
@sdroege
Copy link
Member

sdroege commented May 5, 2023

Sealing approach from that PR looks good to me. I'll look at the list of traits above next week :)

@bilelmoussaoui
Copy link
Member Author

Does docs embedding works fine for those sealed traits?

@jf2048
Copy link
Member

jf2048 commented May 5, 2023

Seems to work here

@bilelmoussaoui
Copy link
Member Author

This is now done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bilelmoussaoui bilelmoussaoui

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.18.0
Development

No branches or pull requests
3 participants
@sdroege @bilelmoussaoui @jf2048