Skip to content

Commit 01a5517

Browse files
saethlinsdroege
authored andcommitted
Fix heap buffer overflow due to operator precedence
1 parent f54c9b2 commit 01a5517

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

Diff for: glib/src/collections/strv.rs

+3-1
Original file line numberDiff line numberDiff line change
@@ -446,8 +446,10 @@ impl StrV {
446446
if len == 0 {
447447
StrV::default()
448448
} else {
449+
// Allocate space for len + 1 pointers, one pointer for each string and a trailing
450+
// null pointer.
449451
let new_ptr =
450-
ffi::g_malloc(mem::size_of::<*mut c_char>() * len + 1) as *mut *mut c_char;
452+
ffi::g_malloc(mem::size_of::<*mut c_char>() * (len + 1)) as *mut *mut c_char;
451453

452454
// Need to clone every item because we don't own it here
453455
for i in 0..len {

0 commit comments

Comments
 (0)