Avoid repeatedly creating same DotNames in ResteasyReactiveProcessor

This is a follow-up of quarkusio#46464. Given the purpose of the PR was to improve dev mode reload performance, I think it's worth avoid the extra allocations.
gsmet · Feb 26, 2025 · 064f4c8 · 064f4c8
1 parent f35cd36
commit 064f4c8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/...est/deployment/src/main/java/io/quarkus/resteasy/reactive/server/deployment/DotNames.java b/...est/deployment/src/main/java/io/quarkus/resteasy/reactive/server/deployment/DotNames.java
@@ -13,6 +13,7 @@
 final class DotNames {
 
     static final String POPULATE_METHOD_NAME = "populate";
+    static final DotName CLASS_NAME = DotName.createSimple(Class.class.getName());
     static final DotName OBJECT_NAME = DotName.createSimple(Object.class.getName());
     static final DotName STRING_NAME = DotName.createSimple(String.class.getName());
     static final DotName BYTE_NAME = DotName.createSimple(byte.class.getName());

diff --git a/...c/main/java/io/quarkus/resteasy/reactive/server/deployment/ResteasyReactiveProcessor.java b/...c/main/java/io/quarkus/resteasy/reactive/server/deployment/ResteasyReactiveProcessor.java
@@ -737,7 +737,7 @@ public DotName apply(Type type) {
                     if (type.kind() == Type.Kind.CLASS) {
                         return typeName;
                     } else if (type.kind() == Type.Kind.PARAMETERIZED_TYPE
-                            && typeName.equals(DotName.createSimple(Class.class))) {
+                            && DotNames.CLASS_NAME.equals(typeName)) {
                         // spec allows for Class<SubResource> to be returned that the container should instantiate
                         return type.asParameterizedType().arguments().get(0).name();
                     }
@@ -833,7 +833,7 @@ public DotName apply(Type type) {
                         }
 
                         Set<DotName> all = new HashSet<>();
-                        if (dotName.equals(DotName.createSimple(Object.class.getName()))) {
+                        if (DotNames.OBJECT_NAME.equals(dotName)) {
                             all.addAll(returnsBySubResources.keySet());
                             for (DotName name : returnsBySubResources.keySet()) {
                                 //we need to also look for all subclasses and interfaces