Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot undo reload of file #2515

Open
4 tasks done
milahu450 opened this issue Jan 31, 2025 · 3 comments
Open
4 tasks done

cannot undo reload of file #2515

milahu450 opened this issue Jan 31, 2025 · 3 comments

Comments

@milahu450
Copy link

⚠️ This issue respects the following points: ⚠️

  • This is a bug. Not a question or feature request.
  • The topic is not already reported at Issues. (I've searched it).
  • Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
  • The bug is still present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor settings are not touched. In case the issue is resolved there, you don't need to create a bug report. The change will be part of the next Markor update.)

Description

german "Aktualisieren"
in the markdown editor menu

clicking that button wipes the whole edit history
so this (data loss) is a serious bug

Steps to reproduce

  1. edit
  2. menu, reload (german "Aktualisieren")

Information

Android version:
Device:
App Version: 2.14.0

Source

Google Play

Format / File type

Markdown

Additional info / Log

-
@gsantner
Copy link
Owner

gsantner commented Jan 31, 2025

Saving is done automatically. Especially important when you swap to another app or rotate the screen.

What reload does is..reloading from filesystem per title. If file changed by that time already, be it from Markor or another app - your old content is gone yes.

Markor does not make any safety copies or old revisions.

@milahu450
Copy link
Author

markor should treat "reload file"
just like any other edit operation
so it can be reverted with "undo"

@harshad1
Copy link
Collaborator

It was a conscious decision to not have to diff the file on load for undo. We can revisit this if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants