Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort to-do lists (with dialog asking for order) #211

Closed
mjray opened this issue Apr 4, 2018 · 20 comments
Closed

Sort to-do lists (with dialog asking for order) #211

mjray opened this issue Apr 4, 2018 · 20 comments

Comments

@mjray
Copy link

mjray commented Apr 4, 2018

General information

  • App version: 0.3.4 F-Droid
  • System: Android 4.1.2

Description

The ability to sort to-do lists so that tasks get reordered by leading priorities would be a great enhancement, reducing the need to cut and paste so much.

@gsantner
Copy link
Owner

gsantner commented Apr 4, 2018

Open for pull requests

@mjray
Copy link
Author

mjray commented Apr 5, 2018

I barely speak Java and I've no idea how to build this app, let alone understand its structure. A HACKING.md or similar would help. I tried installing gradle, cloning this repository and running "./gradlew help" from it but it just started downloading something else so I don't think that's right.

@gsantner
Copy link
Owner

gsantner commented Apr 5, 2018

download android studio and see the setup guide on that page, that is 99% of what you need. Dont go command line when starting android dev, its more complicated.

Plus maybe take a read on my latest android debug post on https://gsantner.net/ , it should have some info about that above

@mjray
Copy link
Author

mjray commented Apr 5, 2018

Blimey. 1Gb of studio and tools to add what seems like a minor new feature on a 3Mb app. :( It may be a while before I download that, sorry. Is there any lighter way to get started contributing?

@gsantner
Copy link
Owner

gsantner commented Apr 5, 2018

Coding at blind isn't a way todo it, unless you know every call and parameters or the most important ones. Impossible todo this all if one doesnt have prior knowledge about all aspects.

Bandwith and storage isnt a problem nowadays usually.

@subkanthi
Copy link
Contributor

@gsantner Also the plan for this is to automatically prioritize or rearrange after every entry or is the plan to have a button to rearrange.

@gsantner
Copy link
Owner

gsantner commented May 2, 2018

I don't use or have ssen such feature in any of my clients, don't know the exact the flow. I will not implement this, but open for PRs.

I have only one important point: Make it to support Ascending and descending, everyone has different approaches for ordering.

automatic: no. please only implement it non-continued. Maybe at begin/finish of editing, but never while editing, as in only manually via action.

  • Stuff flying around while editing is not very nice,
  • also not when closing keyboard and the new task magically disappears
  • and also not the possible workaround to jump the cursor to the resorted line - other text than before gets visible

@gsantner
Copy link
Owner

gsantner commented May 9, 2018

has somebody started on this? happ about PRs! 😄

@subkanthi
Copy link
Contributor

Hi @gsantner , Not yet will get to this sometime by the end of the week.

@subkanthi
Copy link
Contributor

@gsantner , anyway you are OK to use Rxjava

@gsantner
Copy link
Owner

gsantner commented Jun 3, 2018

don't really want to stuff the app with libraries^^

this one need overridden compare/equals methods usually, no libraries

@subkanthi
Copy link
Contributor

@gsantner I looked at it, In Document.java , the list of ToDo items are stored as one string in _content, its going to be difficult to order it, please let me know if Iam looking at the right one.

@gsantner
Copy link
Owner

gsantner commented Jun 6, 2018

For todo list you have to look into SttTask/SttTaskParserExtensioned, SttCommander. there you have basically need to put in file and run collection.sort(comparator) - and implement some comperators.
best if you implement execution stuff in sttcommander (as in calling sort), and the comperators themself in a new thing called e.g. SttSorters

@gsantner
Copy link
Owner

has somebody started working on this?

@gsantner gsantner changed the title Sort to-do lists Sort to-do lists (with dialog asking for order) Sep 5, 2018
@gsantner
Copy link
Owner

while this is not the whole "search" feature, the upcoming v1.2 Markor update will have context-aware-search for @projects and +contexts. Comes when long pressing the @/tag button.
fadf271

The list of tags/projects (dialog) is sorted alphabetically too now.

@goldmanm
Copy link
Contributor

goldmanm commented Nov 3, 2018

@gsantner, thank you again for a great app. This feature would be really awesome. I'd be interested working on it, though I am busy for the next 6 weeks. If someone else hasn't started working on it in late December, I can start working on it.

Just to clarify the desired user interface when the sorting shortcut is clicked, a box appears where the user selects:

priority, ascending
priority, descending
context, ascending
context, descending
project, ascending
project, descending

cancel       OK

and then the sorting happens.

Also, what is the desired sorting for items with multiple contexts or projects? Should item be placed in the first alphabetical context/project which matches any of the item's context/projects? Should the item be duplicated in all contexts/projects (I think this is a bad idea)? Something else?

@gsantner
Copy link
Owner

gsantner commented Nov 3, 2018

@goldmanm
ui is ok like this.
you can use the existing "SearchOrCustomCreator", makes the ui as above, easy.

multiple: first match on line is fine

@goldmanm goldmanm mentioned this issue Dec 8, 2018
@gsantner
Copy link
Owner

gsantner commented Dec 9, 2018

Done via #449 and 47721f6
Thanks @goldmanm ! 🎉

@gsantner gsantner closed this as completed Dec 9, 2018
@esmoak
Copy link

esmoak commented Jul 5, 2019

I was going to put in a feature request for this, but I saw this and thought I would tag @goldmanm to see if Sort by "Creation Date" and "Completion Date" could be added, hopefully without too much difficulty? If Gregor would be open to the addition.

If I have a workout log in todo format, I can sort by the @ and the + or the A-Z priority, but I can't get it back to chronological. (Probably my fault for the bastardization of the todo.txt format I use to get things done. :) )

@gsantner
Copy link
Owner

gsantner commented Jul 6, 2019

Should be very easy to implement :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants