Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fileformat CSV to view/export as a html table #1980

Closed
4 tasks done
k3b opened this issue Feb 17, 2023 · 5 comments · Fixed by #1988
Closed
4 tasks done

Add fileformat CSV to view/export as a html table #1980

k3b opened this issue Feb 17, 2023 · 5 comments · Fixed by #1988
Assignees
Labels

Comments

@k3b
Copy link
Contributor

k3b commented Feb 17, 2023

⚠️ This issue respects the following points: ⚠️

  • This is a enhancement/feature request. Not a bug or question.
  • The topic is not already reported at Issues. (I've searched it).
  • Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
  • The wanted feature/enhancement is not present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor's settings are not touched. If your desired feature is present, you don't need to open this issue. The change will be part of the next Markor update.)

Description

CSV Files are plain-text files that are used to import and export tabular data from other apps. Many spreadsheet applications like MS-Excel or Libre-Office-Calc can read and write csv.

It would be great if Markor can preview/export csv files as html-tables.


Implementation details:

on android csv files can use these mimeTypes


There is a java lib that can read and write csv at https://opencsv.sourceforge.net/ (License Apache 2)
Gradle dependency implementation 'com.opencsv:opencsv:5.7.1'

I have successfully used the lib in SecUSo/privacy-friendly-finance-manager#52

Information

Android version: 10
Device: lg
App Version: (F-Droid) 2.10.7

Source

F-Droid

Format / File type

Something else (-> Additional info)

Additional info / Log

[CSV File](https://en.wikipedia.org/wiki/Comma-separated_values) 

mimeTypes

* `text/csv` see https://www.rfc-editor.org/rfc/rfc7111
* `text/comma-separated-values` non standard but used by android filemanager
@k3b
Copy link
Contributor Author

k3b commented Feb 17, 2023

Related : discussion #1667

@gsantner
Copy link
Owner

You can open csv with Markor generally as it is currently.

So what this is about is to add a own view-mode/text-converter implementation specific to CSV.

@k3b
Copy link
Contributor Author

k3b commented Feb 17, 2023

So what this is about is to add a own view-mode/text-converter implementation specific to CSV.

this is what i try to implement in the first step.

for syntax highlighting i can imagine the all values of colum get the same rotating color.

Values and header of Column1 is blue, column2 is red, column3 is green, .....

but i donot know if this is possible with the current architecture

@k3b
Copy link
Contributor Author

k3b commented Feb 17, 2023

The development of this ticket is currently blocked by bug #1886 and mergerequest #1983

After manually granting storage permissions through the android-permission-settings is can use the app.....

@k3b
Copy link
Contributor Author

k3b commented Feb 21, 2023

From my point of view: Implementation completed. Waiting for merge.

Follow up ticket #1987 for CsvSyntaxHighlighter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants