New image attachment system often fails

[shamefulCake1]

1. Sometimes it fails randomly
2. It fails if camera orientation is changed
3. It fails if camera is switched between back/front

I'll try to make a proper issue when i get to adb

[harshad1]

Orientation changes will likely break things.

What happens when you change orientation is that dialogs will get closed or closed and re-created without any relevant callbacks set. Working around this is non-trivial.

[shamefulCake1]

Orientation changes will likely break things.

What happens when you change orientation is that dialogs will get closed or closed and re-created without any relevant callbacks set. Working around this is non-trivial.

The old system didn't have this issue.

I might want to bisect it, but I think the issue only appeared one version away.

[shamefulCake1]

Something seems to have changed recently.

Stitching between the front and back cameras doesn't necessarily fall now, and it has generally been more stable.

Sometimes attachments still fail, but about 1 out of 3 almost always works.

[harshad1]

If you are able to share a log with me that would be useful

[shamefulCake1]

Here I have logcat | grep -i markor

01-07 09:46:49.402 23784 23784 W RecentsView: filterSelfTask: pkg= net.gsantner.markor, getPackageName= net.oneplus.launcher                                            01-07 09:46:49.402 23784 23784 D RecentsView: applyLoadPlan: id=91025, cmp=ComponentInfo{net.gsantner.markor/net.gsantner.markor.activity.MainActivity}, uid=0, locked=true                                                     
01-07 09:46:50.565  1494  5335 D ActivityTrigger: activityResumeTrigger: The activity in ApplicationInfo{90a93d0 net.gsantner.markor} is now in focus and seems to be in full-screen mode                                       01-07 09:46:50.565  1494  5335 E ActivityTrigger: activityResumeTrigger: not whiteListednet.gsantner.markor/net.gsantner.markor.activity.DocumentActivity/156           
01-07 09:46:50.569  1494  6166 D ActivityTrigger: activityResumeTrigger: The activity in ApplicationInfo{90a93d0 net.gsantner.markor} is now in focus and seems to be in full-screen mode                                       
01-07 09:46:50.569  1494  6166 E ActivityTrigger: activityResumeTrigger: not whiteListednet.gsantner.markor/net.gsantner.markor.activity.DocumentActivity/156           
01-07 09:46:50.582  1494  1618 D RestartProcessManager: Update Total Launch Times :net.gsantner.markor          01-07 09:46:50.582  1494  1618 D RestartProcessManager: updateSelf :  net.gsantner.markor, size : 30            01-07 09:46:50.582  1494  1618 D RestartProcessManager: Increase Total Launch Time : net.gsantner.markor, times : 4, index : 29                                         
01-07 09:46:50.582  1494  1618 D RestartProcessManager: Last Running Package : net.gsantner.markor , start time 1736218010582                                           
01-07 09:46:50.664 18304 18304 I GoogleInputMethodService: GoogleInputMethodService.onStartInput():1911 onStartInput(EditorInfo{EditorInfo{packageName=net.gsantner.markor, inputType=24001, inputTypeString=Normal[MultiLine|CapSentences], enableLearning=true, autoCorrection=true, autoComplete=true, imeOptions=50000006, privateImeOptions=null, actionName=DONE, actionLabel=null, initialSelStart=63, initialSelEnd=63, initialCapsMode=2000, label=null, fieldId=2131296503, fieldName=null, extras=Bundle[mParcelledData.dataSize=844], hintText=null, hintLocales=[]}}, false)                                               
01-07 09:46:51.864 18304 18304 I GoogleInputMethodService: GoogleInputMethodService.onStartInput():1911 onStartInput(EditorInfo{EditorInfo{packageName=net.gsantner.markor, inputType=0, inputTypeString=NULL, enableLearning=false, autoCorrection=false, autoComplete=false, imeOptions=0, privateImeOptions=null, actionName=UNSPECIFIED, actionLabel=null, initialSelStart=-1, initialSelEnd=-1, initialCapsMode=0, label=null, fieldId=-1, fieldName=null, extras=null, hintText=null, hintLocales=[]}}, false)    
01-07 09:46:52.793  1494  6166 I ActivityManager: START u0 {act=android.media.action.IMAGE_CAPTURE flg=0x3 cmp=android/com.android.internal.app.ResolverActivity clip={text/uri-list U:content://net.gsantner.markor.provider/external_files/storage/emulated/0/Android/data/net.gsantner.markor/files/Pictures/IMG_20250107-094652.jpg} (has extras)} from uid 10191 pid 8876                          
01-07 09:46:52.810  1494  1618 D RestartProcessManager: increase duration : 2228 for net.gsantner.markor        
01-07 09:46:53.668  1494  6166 I ActivityManager: START u0 {act=android.media.action.IMAGE_CAPTURE flg=0x3000003 cmp=com.oneplus.camera/.OPCameraServiceActivity clip={text/uri-list U:content://net.gsantner.markor.provider/external_files/storage/emulated/0/Android/data/net.gsantner.markor/files/Pictures/IMG_20250107-094652.jpg} (has extras)} from uid 10191 pid -1                            01-07 09:46:53.740 10761 10761 V OPCameraServiceActivity: checkStartMode() - Start mode: SERVICE_PHOTO, Media extras: com.oneplus.camera.MediaResultInfo@a744eda - [ extraDurationLimit: 0, extraOutput: content://net.gsantner.markor.provider/external_files/storage/emulated/0/Android/data/net.gsantner.markor/files/Pictures/IMG_20250107-094652.jpg, extraSizeLimit: 0, extraVideoQuality: 0 ], Launch source: NORMAL                                     
01-07 09:47:04.904 10761 12868 E RequestedPhotoSaveTask: onGenerateFilePath() - Fail to create /external_files/storage/emulated/0/Android/data/net.gsantner.markor/files/Pictures                                               
01-07 09:47:04.904 10761 12868 V RequestedPhotoSaveTask: saveMediaToFile() - File path : /external_files/storage/emulated/0/Android/data/net.gsantner.markor/files/Pictures/IMG_20250107-094652.jpg                             
01-07 09:47:04.919 10761 12868 E ImageUtils: decodeOrientation() - Fail to access file /external_files/storage/emulated/0/Android/data/net.gsantner.markor/files/Pictures/IMG_20250107-094652.jpg                               
01-07 09:47:04.919 10761 12868 E ImageUtils: java.io.FileNotFoundException: /external_files/storage/emulated/0/Android/data/net.gsantner.markor/files/Pictures/IMG_20250107-094652.jpg (No such file or directory)              
01-07 09:47:04.919 10761 12868 V RequestedPhotoSaveTask: insertToMediaStore() - Content URI : content://net.gsantner.markor.provider/external_files/storage/emulated/0/Android/data/net.gsantner.markor/files/Pictures/IMG_20250107-094652.jpg                                          

01-07 09:47:04.919 10761 12868 V RequestedPhotoSaveTask: onInsertToGalleryDatabase() - File path: /external_files/storage/emulated/0/Android/data/net.gsantner.markor/files/Pictures/IMG_20250107-094652.jpg, content Uri: content://net.gsantner.markor.provider/external_files/storage/emulated/0/Android/data/net.gsantner.markor/files/Pictures/IMG_20250107-094652.jpg, content values: oneplus_flags=1                                                    

01-07 09:47:04.919 10761 12868 E RequestedPhotoSaveTask: onInsertToGalleryDatabase() - Fail to get media ID from URI : content://net.gsantner.markor.provider/external_files/storage/emulated/0/Android/data/net.gsantner.markor/files/Pictures/IMG_20250107-094652.jpg                 

01-07 09:47:06.155 10761 10761 V OPCameraServiceActivity: setMediaResult() - OK, Uri: content://net.gsantner.markor.provider/external_files/storage/emulated/0/Android/data/net.gsantner.markor/files/Pictures/IMG_20250107-094652.jpg                                                  

01-07 09:47:06.191  1494  3336 D ActivityTrigger: activityResumeTrigger: The activity in ApplicationInfo{90a93d0 net.gsantner.markor} is now in focus and seems to be in full-screen mode                                       

01-07 09:47:06.191  1494  3336 E ActivityTrigger: activityResumeTrigger: not whiteListednet.gsantner.markor/net.gsantner.markor.activity.DocumentActivity/156           
01-07 09:47:06.193  1494  1618 D RestartProcessManager: Update Total Launch Times :net.gsantner.markor         
01-07 09:47:06.193  1494  1618 D RestartProcessManager: updateSelf :  net.gsantner.markor, size : 30            

01-07 09:47:06.193  1494  1618 D RestartProcessManager: Increase Total Launch Time : net.gsantner.markor, times : 5, index : 29                                         
01-07 09:47:06.193  1494  1618 D RestartProcessManager: Last Running Package : net.gsantner.markor , start time 1736218026193                                           

01-07 09:47:06.300 18304 18304 I GoogleInputMethodService: GoogleInputMethodService.onStartInput():1911 onStartInput(EditorInfo{EditorInfo{packageName=net.gsantner.markor, inputType=0, inputTypeString=NULL, enableLearning=false, autoCorrection=false, autoComplete=false, imeOptions=0, privateImeOptions=null, actionName=UNSPECIFIED, actionLabel=null, initialSelStart=-1, initialSelEnd=-1, initialCapsMode=0, label=null, fieldId=-1, fieldName=null, extras=null, hintText=null, hintLocales=[]}}, false)    

01-07 09:47:09.473 18304 18304 I GoogleInputMethodService: GoogleInputMethodService.onStartInput():1911 onStartInput(EditorInfo{EditorInfo{packageName=net.gsantner.markor, inputType=24001, inputTypeString=Normal[MultiLine|CapSentences], enableLearning=true, autoCorrection=true, autoComplete=true, imeOptions=50000006, privateImeOptions=null, actionName=DONE, actionLabel=null, initialSelStart=63, initialSelEnd=63, initialCapsMode=2000, label=null, fieldId=2131296503, fieldName=null, extras=Bundle[mParcelledData.dataSize=844], hintText=null, hintLocales=[]}}, false)                                               

01-07 09:47:10.115  1494  1618 D RestartProcessManager: increase duration : 3922 for net.gsantner.markor        

01-07 09:47:10.135 23784 23784 W RecentsView: filterSelfTask: pkg= net.gsantner.markor, getPackageName= net.oneplus.launcher                                            

01-07 09:47:10.136 23784 23784 D RecentsView: applyLoadPlan: id=91025, cmp=ComponentInfo{net.gsantner.markor/net.gsantner.markor.activity.MainActivity}, uid=0, locked=true                                                     

01-07 09:47:10.522   840  1431 W SurfaceFlinger: Attempting to set client state on removed layer: net.gsantner.markor/net.gsantner.markor.activity.DocumentActivity#0   

01-07 09:47:10.522   840  1431 W SurfaceFlinger: Attempting to destroy on removed layer: net.gsantner.markor/net.gsantner.markor.activity.DocumentActivity#0            

01-07 09:47:10.524   840  1431 W SurfaceFlinger: Attempting to set client state on removed layer: net.gsantner.markor/net.gsantner.markor.activity.DocumentActivity#0   

01-07 09:47:10.524   840  1431 W SurfaceFlinger: Attempting to destroy on removed layer: net.gsantner.markor/net.gsantner.markor.activity.DocumentActivity#0     
       

[harshad1]

What did you observe on device when these logs were generated? Did the process just fail silently? Was there a crash?

[shamefulCake1]

There is no crash, and the issue is not happening 100% of the time.

It works like this:

1. I tap "attach image" in the lower-right corner.
2. The popup with source selection appears (browse filesystem, camera picture, gallery picture, edit picture), with two empty fields "description" and "url"
3. I tap on either "camera picture" or "gallery picture"
4. I navigate either the camera or the gallery, and eventually select the picture
5. (If attachment fails) I am back to the image selection popup, and both Url and Description are still empty.
6. I can retry the same action until it succeeds, in which case I am not getting the attachment popup with fields filled-in, I am rather getting a normal attachment line in the file.

There is no crash or error report.

Unlike the OP-post, the remaining issue is not a blocker. It's merely annoying.

And it does not seem to be related to the orientation or back-front camera switching, because a gallery has nothing like an orientation.

[harshad1]

Can you check if the image was actually copied to your notebook. By default to a .res or _res directory next to the file you tried to attach to

[shamefulCake1]

It's not copied and the directory is not created.