You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Allow broadcast_poke only with connected socket, create a good error message and fix a documentation (remove "all broadcasting functions may have socket or... as an argument").
While broadcasting to non-socket, force to provide all the assign values. In this case there is no need to read the assign values from the browser.
The only thing is a problematic API, we need to provide the list of other assign values somehow.
But in this case you can't name you assign @using_assigns :) Any other suggestions?
Personally, I like 1st solution the most :) But 3rd may also do the trick, with good error message when not all the assign values are provided.
Additionally, we could implement 3rd solution also in poke - if you provide all the values there is no need to read it from the browser, which improves the performance, especially when having partials with one assign only.
The text was updated successfully, but these errors were encountered:
This is because Drab.Live in general requires connection to the browser, as it is getting the current assigns from there.
There are three available solution for this
Remove
broadcast_poke
. Initially, I did not plan to implement it, changed my mind because of Allow to broadcast using poke / peek #60Allow
broadcast_poke
only with connected socket, create a good error message and fix a documentation (remove "all broadcasting functions may have socket or... as an argument").While broadcasting to non-socket, force to provide all the assign values. In this case there is no need to read the assign values from the browser.
The only thing is a problematic API, we need to provide the list of other assign values somehow.
But in this case you can't name you assign
@using_assigns
:) Any other suggestions?Personally, I like 1st solution the most :) But 3rd may also do the trick, with good error message when not all the assign values are provided.
Additionally, we could implement 3rd solution also in
poke
- if you provide all the values there is no need to read it from the browser, which improves the performance, especially when having partials with one assign only.The text was updated successfully, but these errors were encountered: