Skip to content

Commit c2676ba

Browse files
committed
implements #1438
1 parent fea1daf commit c2676ba

File tree

2 files changed

+11
-14
lines changed

2 files changed

+11
-14
lines changed

IM/tosca/Tosca.py

+9-9
Original file line numberDiff line numberDiff line change
@@ -179,12 +179,6 @@ def to_radl(self, inf_info=None):
179179
else:
180180
# if not create a system
181181
oscar_sys = self._gen_oscar_system(node)
182-
radl.systems.append(oscar_sys)
183-
conf = configure(node.name, None)
184-
radl.configures.append(conf)
185-
level = Tosca._get_dependency_level(node)
186-
cont_items.append(contextualize_item(node.name, conf.name, level))
187-
cloud_id = self._get_placement_property(oscar_sys.name, "cloud_id")
188182

189183
current_num_instances = self._get_current_num_instances(oscar_sys.name, inf_info)
190184
num_instances = num_instances - current_num_instances
@@ -196,9 +190,15 @@ def to_radl(self, inf_info=None):
196190
if vm_ids:
197191
all_removal_list.extend(vm_ids)
198192
Tosca.logger.debug("List of FaaS to delete: %s" % vm_ids)
199-
200-
dep = deploy(oscar_sys.name, num_instances if num_instances > 0 else 0, cloud_id)
201-
radl.deploys.append(dep)
193+
else:
194+
radl.systems.append(oscar_sys)
195+
conf = configure(node.name, None)
196+
radl.configures.append(conf)
197+
level = Tosca._get_dependency_level(node)
198+
cont_items.append(contextualize_item(node.name, conf.name, level))
199+
cloud_id = self._get_placement_property(oscar_sys.name, "cloud_id")
200+
dep = deploy(oscar_sys.name, 1, cloud_id)
201+
radl.deploys.append(dep)
202202
else:
203203
if root_type == "tosca.nodes.Compute":
204204
# Add the system RADL element

test/unit/Tosca.py

+2-5
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,8 @@ def test_tosca_oscar_delete(self):
354354
tosca_data = yaml.safe_dump(tosca_yaml)
355355

356356
tosca = Tosca(tosca_data)
357-
_, radl = tosca.to_radl()
357+
remove_list, radl = tosca.to_radl()
358+
self.assertEqual(remove_list, [])
358359
radl = parse_radl(str(radl))
359360
radl.check()
360361
node = radl.get_configure_by_name('oscar_plants')
@@ -388,10 +389,6 @@ def test_tosca_oscar_delete(self):
388389
self.assertEqual(remove_list, [1])
389390
radl = parse_radl(str(radl))
390391
radl.check()
391-
conf = radl.get_configure_by_name('plants')
392-
self.assertEqual(conf.recipes, None)
393-
self.assertEqual(radl.deploys[0].id, "plants")
394-
self.assertEqual(radl.deploys[0].vm_number, 0)
395392

396393
def test_tosca_remove(self):
397394
tosca_data = read_file_as_string('../files/tosca_remove_no_list.yml')

0 commit comments

Comments
 (0)