Skip to content

Commit 4712bec

Browse files
committed
Fix #1454
1 parent 1834b04 commit 4712bec

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

IM/connectors/OpenStack.py

+10
Original file line numberDiff line numberDiff line change
@@ -584,6 +584,16 @@ def add_dns_entry(self, hostname, domain, ip, auth_data, extra_args=None):
584584
raise NotImplementedError("Should have implemented this")
585585
return True
586586

587+
def del_dns_entry(self, hostname, domain, ip, auth_data, extra_args=None):
588+
# Special case for EGI DyDNS
589+
# format of the hostname: dydns:secret@hostname
590+
if hostname.startswith("dydns:") and "@" in hostname:
591+
self.log_info("DYDNS entry. Cannot be deleted.")
592+
else:
593+
# TODO: https://docs.openstack.org/designate/latest/index.html
594+
raise NotImplementedError("Should have implemented this")
595+
return True
596+
587597
@staticmethod
588598
def map_radl_ost_networks(vm, ost_nets):
589599
"""

test/unit/connectors/OpenStack.py

+1
Original file line numberDiff line numberDiff line change
@@ -787,6 +787,7 @@ def test_60_finalize(self, sleep, get_driver):
787787
driver.ex_remove_security_group_from_node.return_value = True
788788

789789
vm.volumes = ['volid']
790+
vm.dns_entries = [('dydns:secret@test', 'domain.com.', '8.8.8.8')]
790791
success, _ = ost_cloud.finalize(vm, True, auth)
791792

792793
self.assertTrue(success, msg="ERROR: finalizing VM info.")

0 commit comments

Comments
 (0)