Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing on Windows 8 #25

Closed
jimisaacs opened this issue Jun 2, 2013 · 6 comments
Closed

Failing on Windows 8 #25

jimisaacs opened this issue Jun 2, 2013 · 6 comments

Comments

@jimisaacs
Copy link

Getting ENOTEMPTY when trying to clean a directory with various subdirectories and files on Windows 8, through Git bash.

git bash version:
1.8.1.msysgit.1

node v0.10.8 (The default install)
grunt v0.4.1 (Installed locally ran with global grunt-cli)
grunt-contrib-clean v0.4.1

@jimisaacs
Copy link
Author

Update: It fails when running clean as the 2nd to final task of a significantly long build.
I just tried running the clean task step by itself, and it works.
I wonder if on windows, there may be things hanging around, and they need time to clean up themselves before deleting. Not sure what this is, pretty new to windows development myself.

Also, this error is intermittent, but I have been getting it consistently lately. Probably a race condition somewhere.

@shama
Copy link
Member

shama commented Jun 2, 2013

This task is a small wrapper around grunt.file.delete which is a small wrapper around rimraf.sync. It looks related to this issue: isaacs/rimraf#21 Specifically look at this comment: isaacs/rimraf#19 (comment)

@paulmillr
Copy link

I have fixed this.

@shama
Copy link
Member

shama commented Jul 16, 2013

Awesome thank you @paulmillr! Reference isaacs/rimraf@04b22e8

I think it would be a good idea for this plugin to use rimraf directly for now to get this fix. As grunt.file.delete uses a version that would require a minor version bump in grunt.

@cowboy @tkellen Any objection to using rimraf directly here for now?

@tkellen
Copy link
Member

tkellen commented Jul 16, 2013

Anything that reduces a task's dependency on the task runner is a-ok by me. Go for it!

@shama shama closed this as completed in fbac736 Jul 16, 2013
@shama
Copy link
Member

shama commented Jul 16, 2013

Thanks Tyler! Updated to use rimraf directly to get this fix. Published as 0.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants