-
Notifications
You must be signed in to change notification settings - Fork 33
Implement a federation test #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiitk
approved these changes
Aug 20, 2025
Member
Author
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses some of the tools that were originally implemented for the fallback test to implement a test for the federation feature. The test spreads resources across two control plane servers, so that both a client and a server need to use the authority information in the resource URLs to know which control plane server to request each resource from, and they need to contact both control plane servers to get their complete configurations. go-control-plane imposes some constraints on what combinations of resources it will serve, so both control plane servers have all of the server resources, but the specified authorities should cause the server to contact both anyway, and we attempt to confirm that by testing that it has a connection to both control plane servers.
While implementing this, I had to make a couple of changes that impacted the fallback test:
Test runs: